'Re: Review Request: little faster sycoca'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: little faster sycoca
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2011-09-29 18:25:50
Message-ID: 20110929182550.16069.16179 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102723/
-----------------------------------------------------------

(Updated Sept. 29, 2011, 6:25 p.m.)


Review request for kdelibs.


Changes
-------

len is better than le and better than l.
fixed the off by one error in hashKey (thanks Josef).


Description
-------

Using this way to build a for loop: for (const_iterator it=list.constBegin, \
end=list.constEnd ; it != end; ++it) and replacing the count of bits with the \
QBitArray method for doing that. callgrind says:
before: 2984 calls to constBegin, 0,00%. 2960531 calls to constEnd, 2.33%
after: 2921 calls to constBegin, 0,00%. 2921 calls to constEnd, 0.00%

before: calcDiversity, 55.83%  (debug enabled)
after: calcDiversity, 14,46%  (debug enabled)

buildsycoca is still not faster than light, but it is only a four lines patch.


Diffs (updated)
-----

  kdecore/sycoca/ksycocadict.cpp 17ed9ac 

Diff: http://git.reviewboard.kde.org/r/102723/diff/diff


Testing
-------


Thanks,

Jaime Torres Amate


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102723/">http://git.reviewboard.kde.org/r/102723/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>


<p style="color: grey;"><i>Updated Sept. 29, 2011, 6:25 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">len is better than le and better than l. fixed the off by one error in \
hashKey (thanks Josef).</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using this way to build a for loop: for (const_iterator \
it=list.constBegin, end=list.constEnd ; it != end; ++it) and replacing the count of \
bits with the QBitArray method for doing that. callgrind says:
before: 2984 calls to constBegin, 0,00%. 2960531 calls to constEnd, 2.33%
after: 2921 calls to constBegin, 0,00%. 2921 calls to constEnd, 0.00%

before: calcDiversity, 55.83%  (debug enabled)
after: calcDiversity, 14,46%  (debug enabled)

buildsycoca is still not faster than light, but it is only a four lines patch.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/sycoca/ksycocadict.cpp <span style="color: grey">(17ed9ac)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102723/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic