[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: GSoC: Errors handling during file transfer.
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-09-21 13:46:30
Message-ID: 20110921134630.3982.34222 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102388/#review6699
-----------------------------------------------------------
I did not review the code, so I cannot comment on it. What I am concerned a=
bout is how/when this code should be committed. I certainly believe this is=
4.8 material, so it should not be committed to kdelibs/4.7, on the other h=
and, we have no master repo now, so developers/distributions wanting to tes=
t this would have to apply it manually, which is unfortunate for such a big=
feature.
- Christoph
On Aug. 24, 2011, 4:29 p.m., Cyril Oblikov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102388/
> -----------------------------------------------------------
> =
> (Updated Aug. 24, 2011, 4:29 p.m.)
> =
> =
> Review request for kdelibs and David Faure.
> =
> =
> Summary
> -------
> =
> Modeless dialog to handle interactions and modifications in CopyJob.
> =
> =
> Diffs
> -----
> =
> kio/CMakeLists.txt b517621 =
> kio/kio/copyjob.h eb88c7a =
> kio/kio/copyjob.cpp eff7825 =
> kio/kio/interactiondialog/abstractinteractionitem_p.h PRE-CREATION =
> kio/kio/interactiondialog/abstractinteractionmodel.cpp PRE-CREATION =
> kio/kio/interactiondialog/abstractinteractionmodel_p.h PRE-CREATION =
> kio/kio/interactiondialog/allinteractionitem.cpp PRE-CREATION =
> kio/kio/interactiondialog/allinteractionitem_p.h PRE-CREATION =
> kio/kio/interactiondialog/allinteractionmodel.cpp PRE-CREATION =
> kio/kio/interactiondialog/allinteractionmodel_p.h PRE-CREATION =
> kio/kio/interactiondialog/existinginteractionitem.cpp PRE-CREATION =
> kio/kio/interactiondialog/existinginteractionitem_p.h PRE-CREATION =
> kio/kio/interactiondialog/existinginteractionmodel.cpp PRE-CREATION =
> kio/kio/interactiondialog/existinginteractionmodel_p.h PRE-CREATION =
> kio/kio/interactiondialog/interactiondialog.h PRE-CREATION =
> kio/kio/interactiondialog/interactiondialog.cpp PRE-CREATION =
> kio/kio/interactiondialog/interactiondialogtab.cpp PRE-CREATION =
> kio/kio/interactiondialog/interactiondialogtab_p.h PRE-CREATION =
> kio/kio/interactiondialog/renameinteractionwidget.h PRE-CREATION =
> kio/kio/interactiondialog/renameinteractionwidget.cpp PRE-CREATION =
> kio/kio/interactiondialog/requestitemmodel.cpp PRE-CREATION =
> kio/kio/interactiondialog/requestitemmodel_p.h PRE-CREATION =
> kio/kio/interactiondialog/unreadableinteractionitem.cpp PRE-CREATION =
> kio/kio/interactiondialog/unreadableinteractionitem_p.h PRE-CREATION =
> kio/kio/interactiondialog/unreadableinteractionmodel.cpp PRE-CREATION =
> kio/kio/interactiondialog/unreadableinteractionmodel_p.h PRE-CREATION =
> kio/kio/jobuidelegate.h 25e0728 =
> kio/kio/jobuidelegate.cpp 85679c2 =
> =
> Diff: http://git.reviewboard.kde.org/r/102388/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Cyril
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102388/">http://git.reviewboard.kde.org/r/102388/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did not review the \
code, so I cannot comment on it. What I am concerned about is how/when this code \
should be committed. I certainly believe this is 4.8 material, so it should not be \
committed to kdelibs/4.7, on the other hand, we have no master repo now, so \
developers/distributions wanting to test this would have to apply it manually, which \
is unfortunate for such a big feature.</pre> <br />
<p>- Christoph</p>
<br />
<p>On August 24th, 2011, 4:29 p.m., Cyril Oblikov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Cyril Oblikov.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2011, 4:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Modeless dialog to handle interactions and modifications in \
CopyJob.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/CMakeLists.txt <span style="color: grey">(b517621)</span></li>
<li>kio/kio/copyjob.h <span style="color: grey">(eb88c7a)</span></li>
<li>kio/kio/copyjob.cpp <span style="color: grey">(eff7825)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionitem_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/abstractinteractionmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionitem_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/allinteractionmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionitem_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/existinginteractionmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialogtab.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/interactiondialogtab_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/renameinteractionwidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/renameinteractionwidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/requestitemmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/requestitemmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionitem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionitem_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/interactiondialog/unreadableinteractionmodel_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kio/kio/jobuidelegate.h <span style="color: grey">(25e0728)</span></li>
<li>kio/kio/jobuidelegate.cpp <span style="color: grey">(85679c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102388/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic