[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Set the properties action fom mainWindow
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2011-09-04 9:30:35
Message-ID: 20110904093035.9885.95682 () vidsolbach ! de
[Download RAW message or body]
> On May 25, 2011, 10:31 a.m., Christoph Feck wrote:
> > What is the status of this review? Has it been submitted? If yes, pleas=
e close it.
> =
> Alex Fiestas wrote:
> OMG, didn't got the email from the review :/! will look into this tom=
orrow and commit/close/whatever needs to be done.
> =
> Sorry :/
I've marked it as submitted, the change is in KDE/4.7 dunno if I commit it =
or Peter did, anyway it is there.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101076/#review3510
-----------------------------------------------------------
On April 10, 2011, 9:54 a.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101076/
> -----------------------------------------------------------
> =
> (Updated April 10, 2011, 9:54 a.m.)
> =
> =
> Review request for KDE Base Apps.
> =
> =
> Summary
> -------
> =
> In order to have a proper kiosk support in dolphin we should use standard=
actions whether we can. Dolphin does it right but a few exceptions, this t=
ry to fix one of those.
> =
> the properties action from items is made by getting it from the mainWindo=
w::actionCollection but the "properties" action from openViewportContextMen=
u is custom, which bypasses kiosk.
> =
> The patch simply replace the custom properties action and uses the mainWi=
ndow::actionCollection one.
> =
> =
> Diffs
> -----
> =
> dolphin/src/dolphincontextmenu.cpp 0aa82b2 =
> =
> Diff: http://git.reviewboard.kde.org/r/101076/diff
> =
> =
> Testing
> -------
> =
> Compare the result of clicking on the Properties custom action and the st=
andard one.
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101076/">http://git.reviewboard.kde.org/r/101076/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 25th, 2011, 10:31 a.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What is the status of this review? Has it been submitted? If yes, please \
close it.</pre> </blockquote>
<p>On September 4th, 2011, 12:41 a.m., <b>Alex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OMG, didn't got the \
email from the review :/! will look into this tomorrow and commit/close/whatever \
needs to be done.
Sorry :/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've marked it as \
submitted, the change is in KDE/4.7 dunno if I commit it or Peter did, anyway it is \
there.</pre> <br />
<p>- Alex</p>
<br />
<p>On April 10th, 2011, 9:54 a.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated April 10, 2011, 9:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In order to have a proper kiosk support in dolphin we should use \
standard actions whether we can. Dolphin does it right but a few exceptions, this try \
to fix one of those.
the properties action from items is made by getting it from the \
mainWindow::actionCollection but the "properties" action from \
openViewportContextMenu is custom, which bypasses kiosk.
The patch simply replace the custom properties action and uses the \
mainWindow::actionCollection one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compare the result of clicking on the Properties custom action and the \
standard one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphincontextmenu.cpp <span style="color: \
grey">(0aa82b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101076/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic