[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Allow opening files and directories by pressing
From: "Peter Penz" <peter.penz19 () gmail ! com>
Date: 2011-08-29 11:58:35
Message-ID: 20110829115835.5308.34892 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote:
> > Thanks for the update! Looks good and is exactly like the proposal you,=
Frank and I discussed per e-mail. As usual I've added a punch of my nitpic=
king stuff ;-) Please push it to master after fixing, you don't need to add=
another diff here.
> =
> Tirtha Chatterjee wrote:
> I have used itemActivated signal here since itemTriggered is already =
used by DolphinView. Then I noticed that in my previous keyboard-searching =
patch, we use the name 'activation' to mean selection. So is it okay to use=
activation here?
QAbstractItemView also uses the signal 'activated()' for the same meaning a=
s we have, so I'd say using itemActivated() instead of itemTriggered() is f=
ine. Would like to hear Frank's opinion about this, but I'd say please push=
the patch, we can change this afterwards if we change our mind (currently =
I'd also tend to rename the DolphinView signal to 'itemActivated' for consi=
stency).
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102450/#review6128
-----------------------------------------------------------
On Aug. 29, 2011, 9:14 a.m., Tirtha Chatterjee wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102450/
> -----------------------------------------------------------
> =
> (Updated Aug. 29, 2011, 9:14 a.m.)
> =
> =
> Review request for KDE Base Apps and Peter Penz.
> =
> =
> Summary
> -------
> =
> Allow opening files and directories by pressing 'Enter' key. In case mult=
iple files are selected when enter is pressed, all of them are opened. In c=
ase of multiple directories, the first directory gets opened in the current=
tab, while the other directories open in new tabs.
> =
> =
> Diffs
> -----
> =
> dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 =
> dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c =
> dolphin/src/views/dolphinview.h 437f12f =
> dolphin/src/views/dolphinview.cpp 959e4da =
> =
> Diff: http://git.reviewboard.kde.org/r/102450/diff
> =
> =
> Testing
> -------
> =
> Yes, tested and working.
> =
> =
> Thanks,
> =
> Tirtha
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102450/">http://git.reviewboard.kde.org/r/102450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 29th, 2011, 9:40 a.m., <b>Peter Penz</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for \
the update! Looks good and is exactly like the proposal you, Frank and I discussed \
per e-mail. As usual I've added a punch of my nitpicking stuff ;-) Please push it \
to master after fixing, you don't need to add another diff here.</pre> \
</blockquote>
<p>On August 29th, 2011, 11:45 a.m., <b>Tirtha Chatterjee</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have used \
itemActivated signal here since itemTriggered is already used by DolphinView. Then I \
noticed that in my previous keyboard-searching patch, we use the name \
'activation' to mean selection. So is it okay to use activation here?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QAbstractItemView also \
uses the signal 'activated()' for the same meaning as we have, so I'd say \
using itemActivated() instead of itemTriggered() is fine. Would like to hear \
Frank's opinion about this, but I'd say please push the patch, we can change \
this afterwards if we change our mind (currently I'd also tend to rename the \
DolphinView signal to 'itemActivated' for consistency).</pre> <br />
<p>- Peter</p>
<br />
<p>On August 29th, 2011, 9:14 a.m., Tirtha Chatterjee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Peter Penz.</div>
<div>By Tirtha Chatterjee.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2011, 9:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow opening files and directories by pressing 'Enter' key. In \
case multiple files are selected when enter is pressed, all of them are opened. In \
case of multiple directories, the first directory gets opened in the current tab, \
while the other directories open in new tabs.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, tested and working.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistcontroller.h <span style="color: \
grey">(04d4985)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(207535c)</span></li>
<li>dolphin/src/views/dolphinview.h <span style="color: grey">(437f12f)</span></li>
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(959e4da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102450/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic