This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101575/

Any progre=
ss?

- Torgny

On June 10th, 2011, 9:18 p.m., John Layt wrote:

Review request for kdelibs, KDEPIM, KPhotoAlbum, Skrooge, Zanshin, Kev= in Ottens, and David Jarvie.

By John Layt.

Updated June 10, 2011, 9:18 p.m.

Descripti= on

[Sorry this is a post-commit review and took so long to reme=
mber to post. Bad coder, no cookie for you!]

This review is for some new replacement widgets for the popular KDEPIM KDat=
eEdit and KTimeEdit widgets which were copied into a number of other projec=
ts.  These new widgets are clean rewrites (the original widgets have histor=
y back to KDE2 days) with slightly changed api but otherwise should replica=
te the same functionality with a couple of new features.  They will be avai=
lable for use by any apps using kdelibs 4.7.

The 3 new widgets are:

KDateComboBox: A date entry widget derived from KComboBox, the drop-down me=
nu can display a date picker and list of "fancy" dates to choose =
from.  The list of dates can be configured.

KTimeComboBox: A time entry widget derived from KComboBox, the drop-down me=
nu can display a list of times to choose from.  The list of times can be co=
nfigured.

KDateTimeEdit: A KDateTime entry widget combining KDateComboBox and KTimeCo=
mboBox with optional combo's to select the calendar system and time spe=
c as well. This widget should only be used if you want time spec aware data=
 entry.

All widgets can accept a null or invalid input, it is up to the coder to ch=
eck for validity of input using isValid() if required.  All feature options=
 of the widgets can be configured.  All widgets can optionally display a wa=
rning box on focus out if the entry is invalid.  All widgets can be used in=
 Qt Designer.

I'm particularly looking for input on the api, and what QWidget event v=
irtual methods I should be reimplementing to make the classes BIC future-pr=
oof.

Testing <= /h1>

Unit tests written for non-gui functionality.  Gui functiona=
lity tested in Qt Designer.  KDateTimeEdit still has a couple of minor bugs=
, but I didn't want to hold the review up any longer.

Diffs=

kdeui/CMakeLists.txt (1e8b259)
includes/KDateComboBox (PRE-CREATION)
includes/KDateTimeEdit (PRE-CREATION)
includes/KTimeComboBox (PRE-CREATION)
includes/CMakeLists.txt (7a8bc5c)
kdeui/tests/CMakeLists.txt (c7b8026)
kdeui/tests/kdatecomboboxtest.h (PRE-CREAT= ION)
kdeui/tests/kdatecomboboxtest.cpp (PRE-CRE= ATION)
kdeui/tests/kdatetimeedittest.h (PRE-CREAT= ION)
kdeui/tests/kdatetimeedittest.cpp (PRE-CRE= ATION)
kdeui/tests/ktimecomboboxtest.h (PRE-CREAT= ION)
kdeui/tests/ktimecomboboxtest.cpp (PRE-CRE= ATION)
kdeui/widgets/kdatecombobox.h (PRE-CREATIO= N)
kdeui/widgets/kdatecombobox.cpp (PRE-CREAT= ION)
kdeui/widgets/kdatetimeedit.h (PRE-CREATIO= N)
kdeui/widgets/kdatetimeedit.cpp (PRE-CREAT= ION)
kdeui/widgets/kdatetimeedit.ui (PRE-CREATI= ON)
kdeui/widgets/ktimecombobox.h (PRE-CREATIO= N)
kdeui/widgets/ktimecombobox.cpp (PRE-CREAT= ION)
kdewidgets/kde.widgets (9040538)

View Diff

Screensho= ts

Descripti= on

Testing <= /h1> Unit tests written for non-gui functionality. Gui functiona= lity tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs= , but I didn't want to hold the review up any longer.

Diffs=

Screensho= ts

Testing <= /h1>

Unit tests written for non-gui functionality. Gui functiona= lity tested in Qt Designer. KDateTimeEdit still has a couple of minor bugs= , but I didn't want to hold the review up any longer.