[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Make KSambaSharePrivate::getNetUserShareInfo less
From: "Commit Hook" <null () kde ! org>
Date: 2011-08-11 10:47:16
Message-ID: 20110811104716.14580.16968 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/#review5633
-----------------------------------------------------------
This review has been submitted with commit 75d7cc47fc071f2270492b027c01dcfb=
28b089b0 by Albert Astals Cid to branch KDE/4.7.
- Commit
On Aug. 1, 2011, 10:52 p.m., Albert Astals Cid wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102172/
> -----------------------------------------------------------
> =
> (Updated Aug. 1, 2011, 10:52 p.m.)
> =
> =
> Review request for kdelibs and Rodrigo Belem.
> =
> =
> Summary
> -------
> =
> Each time I open a open dialog i get a complain from KSambaSharePrivate::=
getNetUserShareInfo that says
> kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some e=
rrors while running 'net usershare info' =
> kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: "net usershar=
e: usershares are currently disabled"
> With this patch people like me that have never configured that stop recei=
ving the noise on the shell
> =
> =
> Diffs
> -----
> =
> kio/kio/ksambashare.cpp cd878b6 =
> =
> Diff: http://git.reviewboard.kde.org/r/102172/diff
> =
> =
> Testing
> -------
> =
> The noise is gone
> =
> =
> Thanks,
> =
> Albert
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102172/">http://git.reviewboard.kde.org/r/102172/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 75d7cc47fc071f2270492b027c01dcfb28b089b0 by Albert Astals Cid \
to branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On August 1st, 2011, 10:52 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Rodrigo Belem.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2011, 10:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Each time I open a open dialog i get a complain from \
KSambaSharePrivate::getNetUserShareInfo that says kolourpaint(25821) \
KSambaSharePrivate::getNetUserShareInfo: We got some errors while running 'net \
usershare info' kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: \
"net usershare: usershares are currently disabled" With this patch people \
like me that have never configured that stop receiving the noise on the shell </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The noise is gone</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/ksambashare.cpp <span style="color: grey">(cd878b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102172/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic