--===============8792633464680419792== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/ ----------------------------------------------------------- (Updated Aug. 11, 2011, 10:34 a.m.) Review request for kdelibs and Dawit Alemayehu. Changes ------- Whitespace fixes Summary ------- Each time the terminate code triggers my Konqueror crashes, i'm substitutin= g the terminate for just waiting the thread to finish and we just ignoring = it. The code has a race condition in which wait() returns false, then we switch= to the thread and m_autoDelete is still not set and thus noone will delete= the thread. I can add a mutex if you guys think this is unacceptable. Diffs (updated) ----- kio/kio/hostinfo.cpp 344b1d8 = Diff: http://git.reviewboard.kde.org/r/102179/diff Testing ------- When the = kDebug() << "Name look up for" << hostName << "failed"; if triggers i do not get a crash anymore. Thanks, Albert --===============8792633464680419792== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102179/

Review request for kdelibs and Dawit Alemayehu.
By Albert Astals Cid.

Updated Aug. 11, 2011, 10:34 a.m.

Changes 
Whitespace fixes

Descripti= on 

Each time the terminate code triggers my Konqueror crashes, =
i'm substituting the terminate for just waiting the thread to finish an=
d we just ignoring it.

The code has a race condition in which wait() returns false, then we switch=
 to the thread and m_autoDelete is still not set and thus noone will delete=
 the thread. I can add a mutex if you guys think this is unacceptable.

Testing <= /h1> 
When the =

kDebug() << "Name look up for" << hostName << &=
quot;failed";
if triggers i do not get a crash anymore.

Diffs= (updated)

  • kio/kio/hostinfo.cpp (344b1d8)

View Diff
--===============8792633464680419792==--