Review request for kdelibs and Dawit Alemayehu.
By Albert Astals Cid.
Updated Aug. 11, 2011, 10:34 a.m.
Changes
Description
Each time the terminate code triggers my Konqueror crashes, i'm substituting the terminate for just waiting the thread to finish and we just ignoring it.
The code has a race condition in which wait() returns false, then we switch to the thread and m_autoDelete is still not set and thus noone will delete the thread. I can add a mutex if you guys think this is unacceptable.
|
Testing
When the
kDebug() << "Name look up for" << hostName << "failed";
if triggers i do not get a crash anymore.
|
Diffs (updated)
- kio/kio/hostinfo.cpp (344b1d8)
View Diff
|