[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Fix kopete/kdenetwork build against Qt 4.8
From:       David Faure <faure () kde ! org>
Date:       2011-08-11 9:47:18
Message-ID: 1408509.rxmJCqZ2N3 () kailin
[Download RAW message or body]

On Thursday 04 August 2011 07:46:57 Jeremy Whiting wrote:
> Hello,
> 
> Qt 4.8 has a change to moc which makes virtual inheritance from QObject no
> longer possible.  This caused a problem in Jovie that was fixed by not
> virtually inheriting from QObject anymore.  There is a similar compile
> problem in kdenetwork/kopete/libkopete at the moment and the attached patch
> fixes the problem.  I can commit to 4.7 and trunk if it looks good to
> others.

Looks definitely good. Virtual inheritance has only given us trouble, with 
things like qobjects. +1 for getting rid of 'virtual' there.

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

[prev in list] [next in list] [prev in thread] [next in thread]