From kde-core-devel Wed Aug 10 10:38:10 2011 From: "Christoph Feck" Date: Wed, 10 Aug 2011 10:38:10 +0000 To: kde-core-devel Subject: Re: Review Request: Fix missing "..." in KBookmarkAction displayed Message-Id: <20110810103810.2983.50300 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=131297273822767 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9025262805582500761==" --===============9025262805582500761== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 9, 2011, 10:45 p.m., David Faure wrote: > > Since you're setting iconText, this is about actions into a toolbar, no= t into a menu, right? > > = > > So Qt strips "..." from toolbar button texts? What's the logic there? I= 'm just curious, the patch looks ok, from your description. The logic behind this stripping is to show "Open" instead of "Open..." on t= oolbar buttons. Ideally, Qt would only strip trailing ellipsis, but it doesn't, probably to= handle trailing spaces etc. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5554 ----------------------------------------------------------- On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102262/ > ----------------------------------------------------------- > = > (Updated Aug. 9, 2011, 3:32 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > When a bookmark name, is too long, its name is truncated with "..." at th= e middle. > But, QAction strip those three dots by default. > This patch solves this issue by defining imageText. = > = > = > Diffs > ----- > = > kio/bookmarks/kbookmarkmenu.cc 873f4a8 = > = > Diff: http://git.reviewboard.kde.org/r/102262/diff > = > = > Testing > ------- > = > It works with Konqueror and rekonq. > = > = > Thanks, > = > Yoann > = > --===============9025262805582500761== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102262/

On August 9th, 2011, 10:45 p.m., David Faur= e wrote:

Since you=
're setting iconText, this is about actions into a toolbar, not into a =
menu, right?

So Qt strips "..." from toolbar button texts? What's the logi=
c there? I'm just curious, the patch looks ok, from your description.

The logic b=
ehind this stripping is to show "Open" instead of "Open...&q=
uot; on toolbar buttons.

Ideally, Qt would only strip trailing ellipsis, but it doesn't, probabl=
y to handle trailing spaces etc.

- Christoph

On August 9th, 2011, 3:32 p.m., Yoann Laissus wrote:

Review request for kdelibs.

By Yoann Laissus.

Updated Aug. 9, 2011, 3:32 p.m.

Descripti= on

When a bookmark name, is too long, its name is truncated wit=
h "..." at the middle.
But, QAction strip those three dots by default.
This patch solves this issue by defining imageText.

Testing <= /h1>

It works with Konqueror and rekonq.

Diffs=

kio/bookmarks/kbookmarkmenu.cc (873f4a8)

--===============9025262805582500761==--