[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Umpteenth try to fix KCharSelect crash
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2011-08-10 8:05:44
Message-ID: 20110810080544.26501.2868 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102263/#review5569
-----------------------------------------------------------
Fixes the crash for me.
- Albert
On Aug. 9, 2011, 4:34 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102263/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2011, 4:34 p.m.)
>
>
> Review request for kdelibs and Albert Astals Cid.
>
>
> Summary
> -------
>
> This is definitively my last try to fix the KCharSelect crash.
>
>
> This addresses bug 235020.
> http://bugs.kde.org/show_bug.cgi?id=235020
>
>
> Diffs
> -----
>
> kdeui/widgets/kcharselect.cpp c511191
> kdeui/widgets/kcharselect_p.h d414d23
>
> Diff: http://git.reviewboard.kde.org/r/102263/diff
>
>
> Testing
> -------
>
> I NEVER could reproduce the crash, so I don't know if this changes anything at all.
>
>
> Thanks,
>
> Christoph
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102263/">http://git.reviewboard.kde.org/r/102263/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes the crash for \
me.</pre> <br />
<p>- Albert</p>
<br />
<p>On August 9th, 2011, 4:34 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Albert Astals Cid.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2011, 4:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is definitively my last try to fix the KCharSelect crash.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I NEVER could reproduce the crash, so I don't know if this changes \
anything at all.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=235020">235020</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kcharselect.cpp <span style="color: grey">(c511191)</span></li>
<li>kdeui/widgets/kcharselect_p.h <span style="color: grey">(d414d23)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102263/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic