This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/

Ok, then there's something wrong. QHostInfo has had a blocking method since Qt 4.0.

- Thiago


On August 2nd, 2011, 11:30 a.m., Albert Astals Cid wrote:

Review request for kdelibs and Dawit Alemayehu.
By Albert Astals Cid.

Updated Aug. 2, 2011, 11:30 a.m.

Description

Each time the terminate code triggers my Konqueror crashes, i'm substituting the terminate for just waiting the thread to finish and we just ignoring it.

The code has a race condition in which wait() returns false, then we switch to the thread and m_autoDelete is still not set and thus noone will delete the thread. I can add a mutex if you guys think this is unacceptable.

Testing

When the 
kDebug() << "Name look up for" << hostName << "failed";
if triggers i do not get a crash anymore.

Diffs

  • kio/kio/hostinfo.cpp (fef39fc)

View Diff