--===============0357982205500394027== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/#review5389 ----------------------------------------------------------- > it is missing the code to delete the files And I doubt we will be able to solve this. * Delete thumbnails of files that are no longer present? I have thumbnails = from files of external hard disks, and I rather would like to keep them whe= n unmounting those disks. * Delete thumbnails of files that are accessed long ago? My file systems ar= e mounted in a way to not track read accesses, so it cannot know if a file = has been recently used. Instead of constantly deleting the wrong files, you could rather fire Sweep= er and delete all of them. Being notified about the space issue is an impro= vement, though. What I rather would like to see: * Being able to manually browse/delete thumbnails by path: A thumbnail:// k= ioslave basically, that keeps the folder hierarchy. * Integration with Nepomuk, so that thumbnails automatically get moved/dele= ted when the original file is. Yes, this means not to use (or do a complete overhaul of) the thumbnail spe= cs. - Christoph On July 25, 2011, 1:58 p.m., Jaime Torres Amate wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102083/ > ----------------------------------------------------------- > = > (Updated July 25, 2011, 1:58 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > This is not yet complete, it is missing the code to delete the files, tra= iling spaces and comments in spanish. (coming in next patch version) > = > There are also some things I'm not sure how should be done... > The translations in .notifyrc and .desktop files, should be removed or ju= st keep the lines with an empty traslation? > Classes names, method names and variable names are OK? > = > = > This addresses bug 79943. > http://bugs.kde.org/show_bug.cgi?id=3D79943 > = > = > Diffs > ----- > = > directoryusagenotifier/module.cpp PRE-CREATION = > directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATIO= N = > directoryusagenotifier/module.h PRE-CREATION = > directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION = > directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION = > directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION = > directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION = > directoryusagenotifier/Messages.sh PRE-CREATION = > directoryusagenotifier/README PRE-CREATION = > directoryusagenotifier/cleanupdirectory.h PRE-CREATION = > directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION = > directoryusagenotifier/directoryusagenotifier.h PRE-CREATION = > directoryusagenotifier/CMakeLists.txt PRE-CREATION = > directoryusagenotifier/COPYING PRE-CREATION = > CMakeLists.txt 89d97cd = > directoryusagenotifier/settings.kcfgc PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/102083/diff > = > = > Testing > ------- > = > It works as expected (except it does not yet clean the directory). > = > = > Thanks, > = > Jaime Torres > = > --===============0357982205500394027== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102083/ |
> it is= missing the code to delete the files And I doubt we will be able to solve this. * Delete thumbnails of files that are no longer present? I have thumbnails = from files of external hard disks, and I rather would like to keep them whe= n unmounting those disks. * Delete thumbnails of files that are accessed long ago? My file systems ar= e mounted in a way to not track read accesses, so it cannot know if a file = has been recently used. Instead of constantly deleting the wrong files, you could rather fire Sweep= er and delete all of them. Being notified about the space issue is an impro= vement, though. What I rather would like to see: * Being able to manually browse/delete thumbnails by path: A thumbnail:// k= ioslave basically, that keeps the folder hierarchy. * Integration with Nepomuk, so that thumbnails automatically get moved/dele= ted when the original file is. Yes, this means not to use (or do a complete overhaul of) the thumbnail spe= cs.
- Christoph
On July 25th, 2011, 1:58 p.m., Jaime Torres Amate wrote:
Review request for kdelibs.
By Jaime Torres Amate.
Updated July 25, 2011, 1:58 p.m. Descripti= on
Testing <= /h1>
Bugs:
79943
Diffs=
|