--===============3009112438885382952== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102179/#review5371 ----------------------------------------------------------- QHostInfo is already threaded. This code is unnecessary today and should be= removed. - Thiago On Aug. 2, 2011, 11:30 a.m., Albert Astals Cid wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102179/ > ----------------------------------------------------------- > = > (Updated Aug. 2, 2011, 11:30 a.m.) > = > = > Review request for kdelibs and Dawit Alemayehu. > = > = > Summary > ------- > = > Each time the terminate code triggers my Konqueror crashes, i'm substitut= ing the terminate for just waiting the thread to finish and we just ignorin= g it. > = > The code has a race condition in which wait() returns false, then we swit= ch to the thread and m_autoDelete is still not set and thus noone will dele= te the thread. I can add a mutex if you guys think this is unacceptable. > = > = > Diffs > ----- > = > kio/kio/hostinfo.cpp fef39fc = > = > Diff: http://git.reviewboard.kde.org/r/102179/diff > = > = > Testing > ------- > = > When the = > kDebug() << "Name look up for" << hostName << "failed"; > if triggers i do not get a crash anymore. > = > = > Thanks, > = > Albert > = > --===============3009112438885382952== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102179/ 

QHostInfo =
is already threaded. This code is unnecessary today and should be removed.<=
/pre>
 









- Thiago






On August 2nd, 2011, 11:30 a.m., Albert Astals Cid wrote:









 

  


Review request for kdelibs and Dawit Alemayehu.


By Albert Astals Cid.




Updated Aug. 2, 2011, 11:30 a.m.






Descripti=
on 



 

  
   
Each time the terminate code triggers my Konqueror crashes, =
i'm substituting the terminate for just waiting the thread to finish an=
d we just ignoring it.

The code has a race condition in which wait() returns false, then we switch=
 to the thread and m_autoDelete is still not set and thus noone will delete=
 the thread. I can add a mutex if you guys think this is unacceptable.

  		
 






Testing <=
/h1>


 

  
   
When the =

kDebug() << "Name look up for" << hostName << &=
quot;failed";
if triggers i do not get a crash anymore.

  		
 








Diffs=
 


    

 
  • kio/kio/hostinfo.cpp (fef39fc)
    • 





View Diff
--===============3009112438885382952==--