[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Improve Calculate/Stop buttons when folder Size
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2011-07-30 14:51:52
Message-ID: 20110730145152.12001.94341 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102149/
-----------------------------------------------------------
(Updated July 30, 2011, 2:51 p.m.)
Review request for kdelibs.
Changes
-------
Sorry for the noise again. Forgot a screenshot :)
Summary
-------
This patch improves the Calculate and Stop buttons in folder properties.
Instead of having two buttons that are enabled/disabled accordingly, we onl=
y have one that toggles (technically there are still two buttons but it loo=
ks as if there was one)
I removed that "Calculating..." label when there is already a size shown, i=
nstead the stop button says "Stop Calculating" and somehow serves as "indic=
ator".
Also, I added a line-break after the "Calculating..." so the label doesn't =
change its size making the other elements moving around.
I don't know if the additional icons (view-refresh and process-cancel) add =
too much clutter to the visual interface since this features is not sooo im=
portant/frequently used(?) that the buttons need an icon.
Diffs
-----
kio/kfile/kpropertiesdialog.cpp ba56f18 =
Diff: http://git.reviewboard.kde.org/r/102149/diff
Testing
-------
Compiles and the buttons toggle (and react) fine.
Screenshots
-----------
Screenshot of the dialog while it is calculating
http://git.reviewboard.kde.org/r/102149/s/213/
Thanks,
Kai Uwe
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102149/">http://git.reviewboard.kde.org/r/102149/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 30, 2011, 2:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sorry for the noise again. Forgot a screenshot :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch improves the Calculate and Stop buttons in folder properties. \
Instead of having two buttons that are enabled/disabled accordingly, we only have one \
that toggles (technically there are still two buttons but it looks as if there was \
one)
I removed that "Calculating..." label when there is already a size shown, \
instead the stop button says "Stop Calculating" and somehow serves as \
"indicator". Also, I added a line-break after the \
"Calculating..." so the label doesn't change its size making the other \
elements moving around.
I don't know if the additional icons (view-refresh and process-cancel) add too \
much clutter to the visual interface since this features is not sooo \
important/frequently used(?) that the buttons need an icon.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and the buttons toggle (and react) fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(ba56f18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102149/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102149/s/213/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/07/30/48_PROPERTIESDIALOG_400x100.png" \
style="border: 1px black solid;" alt="Screenshot of the dialog while it is \
calculating" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic