[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Use platform palette and fonts when running on
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2011-07-28 9:13:55
Message-ID: 20110728091355.8527.23910 () vidsolbach ! de
[Download RAW message or body]
> On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote:
> > hmm. but now things are still done twice in a kde session, no?
> > what was wrong with the suggestion to notify qt that it should update "stuff"?
>
> Aurélien Gâteau wrote:
> createApplicationPalette() is indeed called twice when running on a KDE session, but it is \
> not a regression introduced by this change so I think it is outside of the scope for now. I \
> tried not doing anything in kdisplaySetPalette() and call qt_x11_apply_settings_in_all_apps() \
> from the kcm as Olivier suggested, but that didn't work: the palette change was not \
> propagated to the running application.
> What worries me right now is that the text area of KWrite does not get updated at runtime. I \
> thought it was due to the widget being custom, but it correctly updates itself without the \
> patch.
> Aurélien Gâteau wrote:
> Finally found time to do more testing. It turns out the behavior of KWrite text area is the \
> same with or without the patch so it's not a regression. Therefore, I think the patch should \
> go in.
> Thomas Lübking wrote:
> Sh*t - i forgot that I wanted to comment on that: kate keeps own color schemes for the text \
> area, they're completely unrelated to he rest of the system. (since you need to configure \
> syntax highlightning and don't want that to run into a conflict with the system palette de \
> toujours)
> So yes, that's not a regression for sure, sorry.
>
> Dominik Haumann wrote:
> With regard to kwrite: It uses the system colors as long as they were never changed. Changed \
> once, these system settings are overwritten. Hence, this is very likely a KatePart issue.
> Aurélien Gâteau wrote:
> Oh. Thanks Thomas and Dominik, it suddenly makes more sense! If there is no other objection \
> I'd like to merge this patch this week. Anyone against that?
> Aurélien Gâteau wrote:
> I just merged the changes in. Unless I spot some obvious regressions, I plan to backport the \
> patch in time for 4.7.1.
> Frank Reininghaus wrote:
> Could it be that your commit caused the recent kglobalsettingstest failures seen on CDash?
>
> http://my.cdash.org/testSummary.php?project=16&name=kdeui-kglobalsettingstest&date=2011-07-25
>
> On my machine (kongresszentrum), the kde-devel user runs the unit tests in a Konsole inside \
> the regular user's KDE 4.6 session.
That's quite possible indeed. Looking into it.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101805/#review4333
-----------------------------------------------------------
On July 2, 2011, 9:19 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101805/
> -----------------------------------------------------------
>
> (Updated July 2, 2011, 9:19 p.m.)
>
>
> Review request for kdelibs and Olivier Goffart.
>
>
> Summary
> -------
>
> When a KDE application is running on GNOME it looks odd right now because it does not use the \
> GNOME palette and fonts, contrary to Qt-only applications. Attached patch fixes this by \
> relying on the platform plugin to set the correct palette and fonts if we are not running in \
> a full KDE session.
> Patch was suggested by Olivier Goffart.
>
>
> Diffs
> -----
>
> kdeui/kernel/kglobalsettings.cpp 1a497c7
>
> Diff: http://git.reviewboard.kde.org/r/101805/diff
>
>
> Testing
> -------
>
> # On KDE
> - Run kwrite on KDE => KDE palette and fonts
> - Change palette and fonts from System Settings => kwrite updates itself correctly
>
> # On GNOME
> - Run kwrite on GNOME => GNOME palette and fonts
> - Change palette and fonts from GNOME Tweak Tool => palette gets applied, font does not for \
> now
>
> Thanks,
>
> Aurélien
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101805/">http://git.reviewboard.kde.org/r/101805/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 2nd, 2011, 9:49 p.m., <b>Oswald Buddenhagen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">hmm. but now things are still done twice in a \
kde session, no? what was wrong with the suggestion to notify qt that it should update \
"stuff"?</pre> </blockquote>
<p>On July 3rd, 2011, 2:52 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">createApplicationPalette() is indeed called \
twice when running on a KDE session, but it is not a regression introduced by this change so I \
think it is outside of the scope for now. I tried not doing anything in kdisplaySetPalette() \
and call qt_x11_apply_settings_in_all_apps() from the kcm as Olivier suggested, but that \
didn't work: the palette change was not propagated to the running application.
What worries me right now is that the text area of KWrite does not get updated at runtime. I \
thought it was due to the widget being custom, but it correctly updates itself without the \
patch.</pre> </blockquote>
<p>On July 16th, 2011, 10:35 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Finally found time to do more testing. It \
turns out the behavior of KWrite text area is the same with or without the patch so it's \
not a regression. Therefore, I think the patch should go in.</pre> </blockquote>
<p>On July 16th, 2011, 10:42 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Sh*t - i forgot that I wanted to comment on \
that: kate keeps own color schemes for the text area, they're completely unrelated to he \
rest of the system. (since you need to configure syntax highlightning and don't want that \
to run into a conflict with the system palette de toujours)
So yes, that's not a regression for sure, sorry.</pre>
</blockquote>
<p>On July 17th, 2011, 6:43 a.m., <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">With regard to kwrite: It uses the system \
colors as long as they were never changed. Changed once, these system settings are overwritten. \
Hence, this is very likely a KatePart issue.</pre> </blockquote>
<p>On July 17th, 2011, 9:27 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Oh. Thanks Thomas and Dominik, it suddenly \
makes more sense! If there is no other objection I'd like to merge this patch this week. \
Anyone against that?</pre> </blockquote>
<p>On July 22nd, 2011, 8:48 p.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">I just merged the changes in. Unless I spot \
some obvious regressions, I plan to backport the patch in time for 4.7.1.</pre> </blockquote>
<p>On July 25th, 2011, 5:16 p.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Could it be that your commit caused the \
recent kglobalsettingstest failures seen on CDash?
http://my.cdash.org/testSummary.php?project=16&name=kdeui-kglobalsettingstest&date=2011-07-25
On my machine (kongresszentrum), the kde-devel user runs the unit tests in a Konsole inside the \
regular user's KDE 4.6 session.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">That's quite possible indeed. Looking \
into it.</pre> <br />
<p>- Aurélien</p>
<br />
<p>On July 2nd, 2011, 9:19 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and Olivier Goffart.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated July 2, 2011, 9:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a KDE \
application is running on GNOME it looks odd right now because it does not use the GNOME \
palette and fonts, contrary to Qt-only applications. Attached patch fixes this by relying on \
the platform plugin to set the correct palette and fonts if we are not running in a full KDE \
session.
Patch was suggested by Olivier Goffart.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"># On \
KDE
- Run kwrite on KDE => KDE palette and fonts
- Change palette and fonts from System Settings => kwrite updates itself correctly
# On GNOME
- Run kwrite on GNOME => GNOME palette and fonts
- Change palette and fonts from GNOME Tweak Tool => palette gets applied, font does not for \
now</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(1a497c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101805/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic