[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix logic with clear-button animation in klineedit
From: "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date: 2011-07-27 23:45:51
Message-ID: 20110727234551.16152.52532 () vidsolbach ! de
[Download RAW message or body]
> On July 26, 2011, 10:46 p.m., Aleix Pol Gonzalez wrote:
> > kdeui/widgets/klineedit.cpp, line 358
> > <http://git.reviewboard.kde.org/r/102095/diff/1/?file=30032#file30032line358>
> >
> > Wouldn't it be better to put it this way? Just saying...
> >
> > d->clearButton->animateVisible(d->wideEnoughForClear && text.length() > 0);
>
> Nicolas Alvarez wrote:
> I think the original is clearer, to be honest.
I agree with Nicolas.
I have nothing against putting boolean test inside the method call, *in principle*, \
but I believe it's convenient only if the boolean condition is "short enough" to \
write.
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102095/#review5129
-----------------------------------------------------------
On July 26, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102095/
> -----------------------------------------------------------
>
> (Updated July 26, 2011, 9:54 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> Details:
> - fixes the somewhat incorrect logic in KLineEditButton::animateVisible
> - simplifies KLineEdit::updateClearButtonIcon consequently.
>
>
> This addresses bug 268898.
> http://bugs.kde.org/show_bug.cgi?id=268898
>
>
> Diffs
> -----
>
> kdeui/widgets/klineedit.cpp 8f1c8a4
> kdeui/widgets/klineedit_p.h 95016bd
>
> Diff: http://git.reviewboard.kde.org/r/102095/diff
>
>
> Testing
> -------
>
> tested with klineedittest found in kdelibs/kdeui/tests, this with and without the \
> patch attached to comment #1 of bug 268898, used to actually trigger the mentionned \
> bug. Also tested with other klineEdit implementation such as Dolphin's location \
> bar.
>
> Thanks,
>
> Hugo
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102095/">http://git.reviewboard.kde.org/r/102095/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 26th, 2011, 10:46 p.m., <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102095/diff/1/?file=30032#file30032line358" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/widgets/klineedit.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KLineEdit::updateClearButtonIcon(const QString& text)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">349</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">d</span><span \
class="o">-></span><span class="n">wideEnoughForClear</span> <span \
class="o">&&</span> <span class="n">text</span><span class="p">.</span><span \
class="n">length</span><span class="p">()</span> <span class="o">></span> <span \
class="mi">0</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be \
better to put it this way? Just saying...
d->clearButton->animateVisible(d->wideEnoughForClear && \
text.length() > 0);</pre> </blockquote>
<p>On July 27th, 2011, 10:52 p.m., <b>Nicolas Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the original is \
clearer, to be honest.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree \
with Nicolas. I have nothing against putting boolean test inside the method call, *in \
principle*, but I believe it's convenient only if the boolean condition is \
"short enough" to write. </pre> <br />
<p>- Hugo</p>
<br />
<p>On July 26th, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated July 26, 2011, 9:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with klineedittest found in kdelibs/kdeui/tests, this with and \
without the patch attached to comment #1 of bug 268898, used to actually trigger the \
mentionned bug. Also tested with other klineEdit implementation such as Dolphin's \
location bar.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268898">268898</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/klineedit.cpp <span style="color: grey">(8f1c8a4)</span></li>
<li>kdeui/widgets/klineedit_p.h <span style="color: grey">(95016bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic