'Re: Review Request: Fix logic with clear-button animation in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix logic with clear-button animation in
From:       "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date:       2011-07-27 8:22:46
Message-ID: 038bca42180ba05d4aff015b3f6005a5.squirrel () webmail ! sf-mail ! de
[Download RAW message or body]

> Details:
> - fixes the somewhat incorrect logic in KLineEditButton::animateVisible
> - simplifies KLineEdit::updateClearButtonIcon consequently.

Please test this also when using Konqueror and edit fields (e.g. login
boxes). There have been some bad regressions about KLineEdit popping up in
Konqueror, e.g. bug:246513. There is also one more regression about the
return handling that I can't find at the moment (Andrea?).

And while I'm at it here is another one: the following HTML fragment will
have a damaged drawing of the line edits which will go away when you hover
the broken place with the mouse. For me it looks like the clear button was
originally drawn at that place and then it was removed because the input
is disabled. I only managed to create a small self-contained testcase
right now so there is no bug report yet. Will add that tonight.

Eike

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
<head>
<title>Disabled button test</title>
<meta http-equiv="content-type" content="text/html; charset=utf-8" />
</head>
<body>
<table>
<tr><th colspan="2">With table around</th></tr>
<tr>
<td><label for="n_name">Name:</label></td>
<td><input id="n_name" type="text" name="n_name" size="60" value="Entry
that needs some space" readonly="true" /></td>
</tr>
</table>
<input id="n_name2" type="text" name="n_name2" size="60" value="Another
entry that needs some space" readonly="true" />
</body>
</html>

[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic