This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102095/

kdeui/widgets/klineedit.cpp (Diff revision 1) 
void KLineEdit::updateClearButtonIcon(const QString& text)
 

    349
    
    if (d->wideEnoughForClear && text.length() > 0) {

  


 





Wouldn't it be better to put it this way? Just saying...

d->clearButton->animateVisible(d->wideEnoughForClear && text.length() > 0);









- Aleix






On July 26th, 2011, 9:54 p.m., Hugo Pereira Da Costa wrote:









 

  


Review request for kdelibs.


By Hugo Pereira Da Costa.




Updated July 26, 2011, 9:54 p.m.






Description 



 

  
   
Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.


  		
 






Testing 



 

  
   
tested with klineedittest found in kdelibs/kdeui/tests, this with and without the patch attached to comment #1 of bug 268898, used to actually trigger the mentionned bug. Also tested with other klineEdit implementation such as Dolphin's location bar.

  		
 








 Bugs: 


 268898







Diffs 


    

 
  • kdeui/widgets/klineedit.cpp (8f1c8a4)
    • 

 
  • kdeui/widgets/klineedit_p.h (95016bd)
    • 





View Diff