--===============6224810961303183494== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102095/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- Details: - fixes the somewhat incorrect logic in KLineEditButton::animateVisible - simplifies KLineEdit::updateClearButtonIcon consequently. This addresses bug 268898. http://bugs.kde.org/show_bug.cgi?id=3D268898 Diffs ----- kdeui/widgets/klineedit.cpp 8f1c8a4 = kdeui/widgets/klineedit_p.h 95016bd = Diff: http://git.reviewboard.kde.org/r/102095/diff Testing ------- tested with klineedittest found in kdelibs/kdeui/tests, this with and witho= ut the patch attached to comment #1 of bug 268898, used to actually trigger= the mentionned bug. Also tested with other klineEdit implementation such a= s Dolphin's location bar. Thanks, Hugo --===============6224810961303183494== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102095/

Review request for kdelibs.
By Hugo Pereira Da Costa.

Descripti= on 

Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.

Testing <= /h1> 
tested with klineedittest found in kdelibs/kdeui/tests, this=
 with and without the patch attached to comment #1 of bug 268898, used to a=
ctually trigger the mentionned bug. Also tested with other klineEdit implem=
entation such as Dolphin's location bar.
Bugs: 268898

Diffs=

  • kdeui/widgets/klineedit.cpp (8f1c8a4)
  • kdeui/widgets/klineedit_p.h (95016bd)

View Diff
--===============6224810961303183494==--