This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102095/

Review request for kdelibs.
By Hugo Pereira Da Costa.

Description 

Details:
- fixes the somewhat incorrect logic in KLineEditButton::animateVisible
- simplifies KLineEdit::updateClearButtonIcon consequently.

Testing 

tested with klineedittest found in kdelibs/kdeui/tests, this with and without the patch attached to comment #1 of bug 268898, used to actually trigger the mentionned bug. Also tested with other klineEdit implementation such as Dolphin's location bar.
Bugs: 268898

Diffs

  • kdeui/widgets/klineedit.cpp (8f1c8a4)
  • kdeui/widgets/klineedit_p.h (95016bd)

View Diff