[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix bug : now KDE widges are shown in Qt Designer
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2011-07-25 17:05:51
Message-ID: 20110725170551.25594.32009 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101804/#review5093
-----------------------------------------------------------
Ship it!
Please commit, I was wondering why my designer only displayed "KDialogButto=
ns", but nothing else.
- Christoph
On June 30, 2011, 12:06 a.m., Artem Serebriyskiy wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101804/
> -----------------------------------------------------------
> =
> (Updated June 30, 2011, 12:06 a.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> Qt designer requires that subclasses of QDesignerCustomWidgetInterface r=
eturn non-empty, valid XML in domXML() function. makewidges generated empty=
string in this function by default. Because of this, kde widges are not sh=
own in qt designer. This patch fix this bug.
> =
> =
> Diffs
> -----
> =
> kdewidgets/makekdewidgets.cpp cb53c04 =
> =
> Diff: http://git.reviewboard.kde.org/r/101804/diff
> =
> =
> Testing
> -------
> =
> My system. Designer now see plugins generated with makewidges. Other plug=
ins must be changed by their authors.
> =
> =
> Thanks,
> =
> Artem
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101804/">http://git.reviewboard.kde.org/r/101804/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please commit, I was \
wondering why my designer only displayed "KDialogButtons", but nothing \
else.</pre> <br />
<p>- Christoph</p>
<br />
<p>On June 30th, 2011, 12:06 a.m., Artem Serebriyskiy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Artem Serebriyskiy.</div>
<p style="color: grey;"><i>Updated June 30, 2011, 12:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Qt designer requires that subclasses of QDesignerCustomWidgetInterface \
return non-empty, valid XML in domXML() function. makewidges generated empty string \
in this function by default. Because of this, kde widges are not shown in qt \
designer. This patch fix this bug.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">My system. Designer now see plugins generated with makewidges. Other \
plugins must be changed by their authors.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdewidgets/makekdewidgets.cpp <span style="color: grey">(cb53c04)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101804/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic