--===============0250504515556348203== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102083/ ----------------------------------------------------------- Review request for kdelibs. Summary ------- This is not yet complete, it is missing the code to delete the files, trail= ing spaces and comments in spanish. (coming in next patch version) There are also some things I'm not sure how should be done... The translations in .notifyrc and .desktop files, should be removed or just= keep the lines with an empty traslation? Classes names, method names and variable names are OK? This addresses bug 79943. http://bugs.kde.org/show_bug.cgi?id=3D79943 Diffs ----- directoryusagenotifier/module.cpp PRE-CREATION = directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION = directoryusagenotifier/module.h PRE-CREATION = directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION = directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION = directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION = directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION = directoryusagenotifier/Messages.sh PRE-CREATION = directoryusagenotifier/README PRE-CREATION = directoryusagenotifier/cleanupdirectory.h PRE-CREATION = directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION = directoryusagenotifier/directoryusagenotifier.h PRE-CREATION = directoryusagenotifier/CMakeLists.txt PRE-CREATION = directoryusagenotifier/COPYING PRE-CREATION = CMakeLists.txt 89d97cd = directoryusagenotifier/settings.kcfgc PRE-CREATION = Diff: http://git.reviewboard.kde.org/r/102083/diff Testing ------- It works as expected (except it does not yet clean the directory). Thanks, Jaime Torres --===============0250504515556348203== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102083/

Review request for kdelibs.

By Jaime Torres Amate.

Descripti= on

This is not yet complete, it is missing the code to delete t=
he files, trailing spaces and comments in spanish. (coming in next patch ve=
rsion)

There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just=
 keep the lines with an empty traslation?
Classes names, method names and variable names are OK?

Testing <= /h1>

It works as expected (except it does not yet clean the direc=
tory).

Bugs: 79943

Diffs=

directoryusagenotifier/module.cpp (PRE-CRE= ATION)
directoryusagenotifier/directoryusagenotifier_prefs_base.ui (PRE-CREATION)
directoryusagenotifier/module.h (PRE-CREAT= ION)
directoryusagenotifier/directoryusagenotifier.notifyrc (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.desktop (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.kcfg (PRE-CREATION)
directoryusagenotifier/directoryusagenotifier.cpp (PRE-CREATION)
directoryusagenotifier/Messages.sh (PRE-CR= EATION)
directoryusagenotifier/README (PRE-CREATIO= N)
directoryusagenotifier/cleanupdirectory.h = (PRE-CREATION)
directoryusagenotifier/cleanupdirectory.cpp (PRE-CREATION)
directoryusagenotifier/CMakeLists.txt (PRE= -CREATION)
directoryusagenotifier/COPYING (PRE-CREATI= ON)
CMakeLists.txt (89d97cd)
directoryusagenotifier/settings.kcfgc (PRE= -CREATION)

--===============0250504515556348203==--