This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101805/

On July 2nd, 2011, 9:49 p.m., Oswald Budden= hagen wrote:

hmm. but =
now things are still done twice in a kde session, no?
what was wrong with the suggestion to notify qt that it should update "=
;stuff"?

On July 3rd, 2011, 2:52 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

createApp=
licationPalette() is indeed called twice when running on a KDE session, but=
 it is not a regression introduced by this change so I think it is outside =
of the scope for now. I tried not doing anything in kdisplaySetPalette() an=
d call qt_x11_apply_settings_in_all_apps() from the kcm as Olivier suggeste=
d, but that didn't work: the palette change was not propagated to the r=
unning application.

What worries me right now is that the text area of KWrite does not get upda=
ted at runtime. I thought it was due to the widget being custom, but it cor=
rectly updates itself without the patch.

On July 16th, 2011, 10:35 p.m., Aur=C3=A9lien G=C3=A2teau wrote:=

Finally f=
ound time to do more testing. It turns out the behavior of KWrite text area=
 is the same with or without the patch so it's not a regression. Theref=
ore, I think the patch should go in.

On July 16th, 2011, 10:42 p.m., Thomas L=C3=BCbking wrote:

Sh*t - i =
forgot that I wanted to comment on that: kate keeps own color schemes for t=
he text area, they're completely unrelated to he rest of the system.
(since you need to configure syntax highlightning and don't want that t=
o run into a conflict with the system palette de toujours)

So yes, that's not a regression for sure, sorry.

On July 17th, 2011, 6:43 a.m., Dominik Haumann wrote:

With rega=
rd to kwrite: It uses the system colors as long as they were never changed.=
 Changed once, these system settings are overwritten. Hence, this is very l=
ikely a KatePart issue.

On July 17th, 2011, 9:27 p.m., Aur=C3=A9lien G=C3=A2teau wrote:<= /p>

Oh. Thank=
s Thomas and Dominik, it suddenly makes more sense! If there is no other ob=
jection I'd like to merge this patch this week. Anyone against that?

I just merg=
ed the changes in. Unless I spot some obvious regressions, I plan to backpo=
rt the patch in time for 4.7.1.

- Aur=C3=A9lien

On July 2nd, 2011, 9:19 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for kdelibs and Olivier Goffart.

By Aur=C3=A9lien G=C3=A2teau.

Updated July 2, 2011, 9:19 p.m.

Descripti= on

When a KDE application is running on GNOME it looks odd righ=
t now because it does not use the GNOME palette and fonts, contrary to Qt-o=
nly applications. Attached patch fixes this by relying on the platform plug=
in to set the correct palette and fonts if we are not running in a full KDE=
 session.

Patch was suggested by Olivier Goffart.

Testing <= /h1>

# On KDE
- Run kwrite on KDE =3D> KDE palette and fonts
- Change palette and fonts from System Settings =3D> kwrite updates itse=
lf correctly

# On GNOME
- Run kwrite on GNOME =3D> GNOME palette and fonts
- Change palette and fonts from GNOME Tweak Tool =3D> palette gets appli=
ed, font does not for now

Diffs=

kdeui/kernel/kglobalsettings.cpp (1a497c7)=

View Diff