[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Only show KSysguard & SystemSettings in menus when
From: "Ben Cooksley" <bcooksley () kde ! org>
Date: 2011-07-22 7:21:08
Message-ID: 20110722072108.14486.80244 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102038/#review4952
-----------------------------------------------------------
1) The git diff you have uploaded is cooked
2) As System Settings maintainer, I find this unacceptable as people using =
KDE applications under other desktops need to access System Settings for th=
e purpose of altering settings shared by KDE applications - and managed thr=
ough System Settings.
Examples:
- Colour scheme
- Style used
- Etc
- Ben
On July 21, 2011, 10:39 p.m., Jeremy Bicha wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102038/
> -----------------------------------------------------------
> =
> (Updated July 21, 2011, 10:39 p.m.)
> =
> =
> Review request for KDE Base Apps.
> =
> =
> Summary
> -------
> =
> Add OnlyShowIn:KDE line to KSysguard & SystemSettings. Otherwise, it's ve=
ry frustrating when running any other desktop (Gnome Shell, Unity, etc.) an=
d seeing multiple apps named the same thing with the same icon without any =
way to distinguish them.
> =
> =
> Diffs
> -----
> =
> ksysguard/gui/ksysguard.desktop 7e8ff32f1e275ee246e79da039509e28e56987c=
f =
> systemsettings/app/systemsettings.desktop 5934a194675cfe152ebdbfd4a9db4=
5ebd48b67a8 =
> =
> Diff: http://git.reviewboard.kde.org/r/102038/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Jeremy
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102038/">http://git.reviewboard.kde.org/r/102038/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) The git diff you have \
uploaded is cooked 2) As System Settings maintainer, I find this unacceptable as \
people using KDE applications under other desktops need to access System Settings for \
the purpose of altering settings shared by KDE applications - and managed through \
System Settings.
Examples:
- Colour scheme
- Style used
- Etc</pre>
<br />
<p>- Ben</p>
<br />
<p>On July 21st, 2011, 10:39 p.m., Jeremy Bicha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Jeremy Bicha.</div>
<p style="color: grey;"><i>Updated July 21, 2011, 10:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add OnlyShowIn:KDE line to KSysguard & SystemSettings. Otherwise, \
it's very frustrating when running any other desktop (Gnome Shell, Unity, etc.) \
and seeing multiple apps named the same thing with the same icon without any way to \
distinguish them. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksysguard/gui/ksysguard.desktop <span style="color: \
grey">(7e8ff32f1e275ee246e79da039509e28e56987cf)</span></li>
<li>systemsettings/app/systemsettings.desktop <span style="color: \
grey">(5934a194675cfe152ebdbfd4a9db45ebd48b67a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102038/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic