From kde-core-devel Sat Jul 02 21:19:55 2011 From: =?utf-8?b?QXVyw6lsaWVuIEfDonRlYXU=?= Date: Sat, 02 Jul 2011 21:19:55 +0000 To: kde-core-devel Subject: Re: Review Request: Use platform palette and fonts when running on Message-Id: <20110702211955.20666.4583 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130964164611619 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3869842841033043393==" --===============3869842841033043393== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101805/ ----------------------------------------------------------- (Updated July 2, 2011, 9:19 p.m.) Review request for kdelibs and Olivier Goffart. Changes ------- Updated to check whether we run in a KDE session. Applied the same change t= o font settings. Summary (updated) ------- When a KDE application is running on GNOME it looks odd right now because i= t does not use the GNOME palette and fonts, contrary to Qt-only application= s. Attached patch fixes this by relying on the platform plugin to set the c= orrect palette and fonts if we are not running in a full KDE session. Patch was suggested by Olivier Goffart. Diffs (updated) ----- kdeui/kernel/kglobalsettings.cpp 1a497c7 = Diff: http://git.reviewboard.kde.org/r/101805/diff Testing (updated) ------- # On KDE - Run kwrite on KDE =3D> KDE palette and fonts - Change palette and fonts from System Settings =3D> kwrite updates itself = correctly # On GNOME - Run kwrite on GNOME =3D> GNOME palette and fonts - Change palette and fonts from GNOME Tweak Tool =3D> palette gets applied,= font does not for now Thanks, Aur=C3=A9lien --===============3869842841033043393== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101805/

Review request for kdelibs and Olivier Goffart.

By Aur=C3=A9lien G=C3=A2teau.

Updated July 2, 2011, 9:19 p.m.

Changes

Updated to check whether we run in a KDE session. Applied th=
e same change to font settings.

Descripti= on (updated)

When a KDE application is running on GNOME it looks odd righ=
t now because it does not use the GNOME palette and fonts, contrary to Qt-o=
nly applications. Attached patch fixes this by relying on the platform plug=
in to set the correct palette and fonts if we are not running in a full KDE=
 session.

Patch was suggested by Olivier Goffart.

Testing (= updated)

# On KDE
- Run kwrite on KDE =3D> KDE palette and fonts
- Change palette and fonts from System Settings =3D> kwrite updates itse=
lf correctly

# On GNOME
- Run kwrite on GNOME =3D> GNOME palette and fonts
- Change palette and fonts from GNOME Tweak Tool =3D> palette gets appli=
ed, font does not for now

Diffs= (updated)

kdeui/kernel/kglobalsettings.cpp (1a497c7)=

--===============3869842841033043393==--