[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    =?utf-8?q?Re=3A_Review_Request=3A_Make_=E2=80=9CEdit_File_Type=E2=80=9D_b?=
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2011-06-30 22:34:32
Message-ID: 20110630223432.20408.5768 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
-----------------------------------------------------------

(Updated June 30, 2011, 10:34 p.m.)


Review request for kdelibs.


Changes
-------

Changed button label to "File Type Options" and moved the button below the type label \
instead of right of it. New screen shot: \
http://privat.broulik.de/filedialogpatch2.png


Summary
-------

On IRC this evening somebody found it hard to find the options to edit a specific \
file type. The KCM is a mess unfortunately but I told him that you could edit \
specific file types directly from the properties dialog. That button is hard to spot, \
though, which I also often found annoying. It is neither labled nor does it stand out \
as "button". This patch solves that issue.

It is in need of discussion whether the label itself should stay but the button \
definitly has to look like a clickable target.

Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot is from \
the initial attempt where i forgot the capitalization :P)


Diffs (updated)
-----

  kio/kfile/kpropertiesdialog.cpp 3382daa 

Diff: http://git.reviewboard.kde.org/r/101800/diff


Testing
-------


Thanks,

Kai Uwe


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101800/">http://git.reviewboard.kde.org/r/101800/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated June 30, 2011, 10:34 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed button label to "File Type Options" and moved the button below \
the type label instead of right of it. New screen shot: \
http://privat.broulik.de/filedialogpatch2.png</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On IRC this evening somebody found it hard to find the options to edit a \
specific file type. The KCM is a mess unfortunately but I told him that you could \
edit specific file types directly from the properties dialog. That button is hard to \
spot, though, which I also often found annoying. It is neither labled nor does it \
stand out as "button". This patch solves that issue.

It is in need of discussion whether the label itself should stay but the button \
definitly has to look like a clickable target.

Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot is from \
the initial attempt where i forgot the capitalization :P)</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(3382daa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101800/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic