From kde-core-devel Wed Jun 22 02:08:03 2011 From: "Dawit Alemayehu" Date: Wed, 22 Jun 2011 02:08:03 +0000 To: kde-core-devel Subject: Re: Review Request: [PATCH] Change HTML thumbnail generator to use Message-Id: <20110622020803.17285.40165 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130870852801839 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5683119796512909444==" --===============5683119796512909444== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/ ----------------------------------------------------------- (Updated June 22, 2011, 2:08 a.m.) Review request for KDE Runtime. Summary ------- The attached patch fixes the html thumbnail generator so that it won't show= the "Open With" dialog box whenever it encounters frames and other content= such as flash. This addresses bug 248478. http://bugs.kde.org/show_bug.cgi?id=3D248478 Diffs ----- kioslave/thumbnail/CMakeLists.txt 9789109 = kioslave/thumbnail/htmlcreator.h 6903db7 = kioslave/thumbnail/htmlcreator.cpp c623606 = Diff: http://git.reviewboard.kde.org/r/101365/diff Testing ------- Tested by generating thumbnails on the Qt HTML documentation folder. Thanks, Dawit --===============5683119796512909444== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101365/

Review request for KDE Runtime.
By Dawit Alemayehu.

Updated June 22, 2011, 2:08 a.m.

Descripti= on 

The attached patch fixes the html thumbnail generator so tha=
t it won't show the "Open With" dialog box whenever it encoun=
ters frames and other content such as flash.

Testing <= /h1> 
Tested by generating thumbnails on the Qt HTML documentation=
 folder.
Bugs: 248478

Diffs=

  • kioslave/thumbnail/CMakeLists.txt (9789109= )
  • kioslave/thumbnail/htmlcreator.h (6903db7)=
  • kioslave/thumbnail/htmlcreator.cpp (c62360= 6)

View Diff
--===============5683119796512909444==--