[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Do not change Konqueror's tab icon on invalid url
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-06-15 5:02:54
Message-ID: 20110615050254.16727.98140 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101626/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

Do not change the tab icon when switching between tabs, if the location bar url is \
invalid, e.g. blank. To duplicate the problem simply empty the location bar and \
switch tabs. The tab you switched from will get the generic folder icon.


This addresses bug 131909.
    http://bugs.kde.org/show_bug.cgi?id=131909


Diffs
-----

  konqueror/src/konqview.cpp efd7f07 

Diff: http://git.reviewboard.kde.org/r/101626/diff


Testing
-------


Thanks,

Dawit


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101626/">http://git.reviewboard.kde.org/r/101626/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not change the tab icon when switching between tabs, if the location \
bar url is invalid, e.g. blank. To duplicate the problem simply empty the location \
bar and switch tabs. The tab you switched from will get the generic folder \
icon.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=131909">131909</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqview.cpp <span style="color: grey">(efd7f07)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101626/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic