[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kshorturifilter plugin code clean up and minor
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-06-14 14:22:01
Message-ID: 20110614142201.5929.51313 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101576/
-----------------------------------------------------------
(Updated June 14, 2011, 2:22 p.m.)
Review request for KDE Runtime.
Changes
-------
Added support for percent encoding extra '@' in username components of a URL.
Summary (updated)
-------
The attached patch does the following:
- Removes the regular expression check for IP addresses since QUrl/KUrl now
correctly parse almost all short url addresses.
- Creates the remaining QRegExp checks once instead of on demand.
- Uses KUser for username name and directory shortcuts, e.g. ~/, resolution.
- Percent-encodes extra '@' within a URL's username component (Workaround).
- Adds unit tests for IPv6 URLs and escaping of '@' in usernames.
This addresses bugs 69326 and 118413.
http://bugs.kde.org/show_bug.cgi?id=69326
http://bugs.kde.org/show_bug.cgi?id=118413
Diffs (updated)
-----
kurifilter-plugins/shorturi/kshorturifilter.h 30bd686
kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca
kurifilter-plugins/tests/kurifiltertest.cpp f2354d8
Diff: http://git.reviewboard.kde.org/r/101576/diff
Testing (updated)
-------
Run the unit test.
Thanks,
Dawit
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101576/">http://git.reviewboard.kde.org/r/101576/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated June 14, 2011, 2:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added support for percent encoding extra '@' in username \
components of a URL.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch does the following:
- Removes the regular expression check for IP addresses since QUrl/KUrl now
correctly parse almost all short url addresses.
- Creates the remaining QRegExp checks once instead of on demand.
- Uses KUser for username name and directory shortcuts, e.g. ~/, resolution.
- Percent-encodes extra '@' within a URL's username component \
(Workaround).
- Adds unit tests for IPv6 URLs and escaping of '@' in usernames.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Run the unit test.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=69326">69326</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=118413">118413</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/shorturi/kshorturifilter.h <span style="color: \
grey">(30bd686)</span></li>
<li>kurifilter-plugins/shorturi/kshorturifilter.cpp <span style="color: \
grey">(78ca7ca)</span></li>
<li>kurifilter-plugins/tests/kurifiltertest.cpp <span style="color: \
grey">(f2354d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101576/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic