'Review Request: Show the correct url in Konqueror when switching to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Show the correct url in Konqueror when switching to
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-06-09 9:20:37
Message-ID: 20110609092037.4463.44937 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101558/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

Show the correct url in Konqueror when switching to a new tab after clearing the url \
of the current tab. Right now if the location bar is cleared using the backspace key \
or the clear button before switching to another tab, the location bar will always be \
empty unless the views are reloaded.

The second issue, not addressed by this patch, is use of the wrong url on reload. To \
see this problem simply 1.) Open two tabs, enter a URL in one and let it finish \
loading.  2.) Start changing the location bar url, but do not press return. 
3.) Switch view to the first tab and switch back. 
4.) Reload the page. 

The incorrect URL, newly typed and potentially invalid URL, will be used for the \
reload request. This issue is caused by a workaround for another bug (#54687) in \
KonqMainWindow::slotReload and requires its own fix.


This addresses bug 187891.
    http://bugs.kde.org/show_bug.cgi?id=187891


Diffs
-----

  konqueror/src/konqmainwindow.cpp a309f48 

Diff: http://git.reviewboard.kde.org/r/101558/diff


Testing
-------


Thanks,

Dawit


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101558/">http://git.reviewboard.kde.org/r/101558/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Show the correct url in Konqueror when switching to a new tab after \
clearing the url of the current tab. Right now if the location bar is cleared using \
the backspace key or the clear button before switching to another tab, the location \
bar will always be empty unless the views are reloaded.

The second issue, not addressed by this patch, is use of the wrong url on reload. To \
see this problem simply 1.) Open two tabs, enter a URL in one and let it finish \
loading.  2.) Start changing the location bar url, but do not press return. 
3.) Switch view to the first tab and switch back. 
4.) Reload the page. 

The incorrect URL, newly typed and potentially invalid URL, will be used for the \
reload request. This issue is caused by a workaround for another bug (#54687) in \
KonqMainWindow::slotReload and requires its own fix.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=187891">187891</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(a309f48)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101558/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic