[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Use QDirIterator in KStandardDirs
From:       "Bernhard Beschow" <bbeschow () cs ! tu-berlin ! de>
Date:       2011-06-09 7:06:10
Message-ID: 20110609070610.30684.78618 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101554/
-----------------------------------------------------------

Review request for kdelibs, kdewin and David Faure.


Summary
-------

Increase portability of kdecore a tiny bit by making KStandardDirs use QDir=
Iterator rater than platform-specific code.


Diffs
-----

  kdecore/kernel/kstandarddirs.cpp ba90270 =


Diff: http://git.reviewboard.kde.org/r/101554/diff


Testing
-------

I'm running my platform 4.6 with this patch and haven't noticed any regress=
ions yet.


Thanks,

Bernhard


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101554/">http://git.reviewboard.kde.org/r/101554/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, kdewin and David Faure.</div>
<div>By Bernhard Beschow.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Increase portability of kdecore a tiny bit by making KStandardDirs use \
QDirIterator rater than platform-specific code.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m running my platform 4.6 with this patch and haven&#39;t noticed \
any regressions yet.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdecore/kernel/kstandarddirs.cpp <span style="color: grey">(ba90270)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101554/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic