[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix possible memory and D-Bus connection leak in
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-06-07 5:44:47
Message-ID: 20110607054447.13331.57734 () vidsolbach ! de
[Download RAW message or body]
> On June 6, 2011, 8:38 p.m., Aaron J. Seigo wrote:
> > i doubt this fix is correct. what looks more like is \
> > KStatusNotifierItemDBus::~KStatusNotifierItemDBus(). right now this is the \
> > implementation:
> > m_dbus.unregisterService(m_service);
> >
> > and perhaps it should include:
> >
> > m_dbus.unregisterObject("/StatusNotifierItem", this);
> >
> > and perhaps even:
> >
> > m_dbus.disconnectFromBus(m_service);
> >
> > (though i expect the latter is done automatically when QDBusConnection is \
> > deleted? maybe not though...)
>
> Shaun Reich wrote:
> actually, looks like ~QDBusConnection() won't close the connection. apparently \
> disconnectFromBus does indeed need to be called explicitly. /me suddenly wonders \
> how much code doesn't do this, if need be.
Dunno if this class is using QDBusConnection::sessionBus(), but if it is then the \
disconnect is supposed to be automatic according to the sessionBus() API \
documentation. If indeed the disconnection is not occurring, then that might possibly \
explain the weird dbus related crashes reported in bug# 234484 as well. I hope that \
is not the case because I do not remember seeing anywhere where disconnectFromBus is \
called explicitly.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101527/#review3726
-----------------------------------------------------------
On June 6, 2011, 3:31 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101527/
> -----------------------------------------------------------
>
> (Updated June 6, 2011, 3:31 p.m.)
>
>
> Review request for kdelibs, Plasma and Marco Martin.
>
>
> Summary
> -------
>
> According to bug 261180 there is a D-Bus connection leak in KStatusNotifierItem. \
> This patch potentially fixes it, but I do not know how to test it.
>
> This addresses bug 261180.
> http://bugs.kde.org/show_bug.cgi?id=261180
>
>
> Diffs
> -----
>
> kdeui/notifications/kstatusnotifieritem.cpp c48ed50
>
> Diff: http://git.reviewboard.kde.org/r/101527/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101527/">http://git.reviewboard.kde.org/r/101527/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 6th, 2011, 8:38 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i doubt this fix is correct. what looks more like is \
KStatusNotifierItemDBus::~KStatusNotifierItemDBus(). right now this is the \
implementation:
m_dbus.unregisterService(m_service);
and perhaps it should include:
m_dbus.unregisterObject("/StatusNotifierItem", this);
and perhaps even:
m_dbus.disconnectFromBus(m_service);
(though i expect the latter is done automatically when QDBusConnection is deleted? \
maybe not though...)</pre> </blockquote>
<p>On June 7th, 2011, 4:07 a.m., <b>Shaun Reich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">actually, looks like \
~QDBusConnection() won't close the connection. apparently disconnectFromBus does \
indeed need to be called explicitly. /me suddenly wonders how much code doesn't \
do this, if need be.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dunno if this class is \
using QDBusConnection::sessionBus(), but if it is then the disconnect is supposed to \
be automatic according to the sessionBus() API documentation. If indeed the \
disconnection is not occurring, then that might possibly explain the weird dbus \
related crashes reported in bug# 234484 as well. I hope that is not the case because \
I do not remember seeing anywhere where disconnectFromBus is called explicitly.</pre> \
<br />
<p>- Dawit</p>
<br />
<p>On June 6th, 2011, 3:31 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Marco Martin.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated June 6, 2011, 3:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to bug 261180 there is a D-Bus connection leak in \
KStatusNotifierItem. This patch potentially fixes it, but I do not know how to test \
it.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=261180">261180</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/notifications/kstatusnotifieritem.cpp <span style="color: \
grey">(c48ed50)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101527/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic