[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: remove functions *Command::name() which are not
From: "David Faure" <faure () kde ! org>
Date: 2011-06-05 23:48:53
Message-ID: 20110605234853.30967.26326 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101343/#review3698
-----------------------------------------------------------
OK, that's one solution. The other solution would be to fix the Undo action=
to actually show the text of the command to undo, like it does in many oth=
er apps ;)
Looking at keditbookmarks, it seems to do that using QUndoStack::createUndo=
Action, which makes sure that the action text is always updated from the te=
xt of the current undo command.
- David
On May 12, 2011, 6:55 a.m., Alexander Potashev wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101343/
> -----------------------------------------------------------
> =
> (Updated May 12, 2011, 6:55 a.m.)
> =
> =
> Review request for KDE Base Apps and David Faure.
> =
> =
> Summary
> -------
> =
> konq-plugins/domtreeviewer builds without there functions.
> =
> May be these functions were left for future integration of domtreeviewer =
undoable commands' into Konqueror's undo stack. But for now, they only add =
a few translatable strings the user won't ever see.
> =
> =
> Diffs
> -----
> =
> konq-plugins/domtreeviewer/domtreecommands.h df8272e =
> konq-plugins/domtreeviewer/domtreecommands.cpp e4c7fff =
> =
> Diff: http://git.reviewboard.kde.org/r/101343/diff
> =
> =
> Testing
> -------
> =
> konq-plugins/domtreeviewer compiles after this change.
> =
> =
> Thanks,
> =
> Alexander
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101343/">http://git.reviewboard.kde.org/r/101343/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, that's one \
solution. The other solution would be to fix the Undo action to actually show the \
text of the command to undo, like it does in many other apps ;)
Looking at keditbookmarks, it seems to do that using QUndoStack::createUndoAction, \
which makes sure that the action text is always updated from the text of the current \
undo command.</pre> <br />
<p>- David</p>
<br />
<p>On May 12th, 2011, 6:55 a.m., Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated May 12, 2011, 6:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">konq-plugins/domtreeviewer builds without there functions.
May be these functions were left for future integration of domtreeviewer undoable \
commands' into Konqueror's undo stack. But for now, they only add a few \
translatable strings the user won't ever see.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">konq-plugins/domtreeviewer compiles after this change.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konq-plugins/domtreeviewer/domtreecommands.h <span style="color: \
grey">(df8272e)</span></li>
<li>konq-plugins/domtreeviewer/domtreecommands.cpp <span style="color: \
grey">(e4c7fff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101343/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic