From kde-core-devel Mon May 30 22:33:18 2011 From: "Dawit Alemayehu" Date: Mon, 30 May 2011 22:33:18 +0000 To: kde-core-devel Subject: Re: Review Request: make the add search engine window right aligned Message-Id: <20110530223318.27276.54813 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130679483620860 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3674382961333109643==" --===============3674382961333109643== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101475/#review3599 ----------------------------------------------------------- Ship it! Would that not simply make the reverse true, i.e. the dialog might be too l= arge in the opposite direction ? Anyhow, at least it won't be outside of th= e konqueror window ; so I personally have no objections to this. - Dawit On May 30, 2011, 8:26 p.m., Burkhard L=C3=BCck wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101475/ > ----------------------------------------------------------- > = > (Updated May 30, 2011, 8:26 p.m.) > = > = > Review request for KDE Base Apps, Dawit Alemayehu and David Faure. > = > = > Summary > ------- > = > Currently the add search engine window is left aligned to the left side o= f the search bar. E. g. using locales with long translations of the window = title "Set URI Shortcuts" (or other strings in the window) like eg fr part = of the window to add the search engine is outside the screen, because the t= ranslated string is longer than the search bar. = > The patch makes the window right aligned at the end of the search bar, th= an no matter how long the translated string is the whole window will be alw= ays inside konquerors main window. > = > Screenshot in locale fr before the patch showing the bug: http://bugsfile= s.kde.org/attachment.cgi?id=3D52424 > = > Screenshot in locale fr with the patch (one with / one without throbber):= http://bugsfiles.kde.org/attachment.cgi?id=3D60484 > = > = > This addresses bug 253879. > http://bugs.kde.org/show_bug.cgi?id=3D253879 > = > = > Diffs > ----- > = > konq-plugins/searchbar/searchbar.cpp c7aa301 = > = > Diff: http://git.reviewboard.kde.org/r/101475/diff > = > = > Testing > ------- > = > = > Thanks, > = > Burkhard > = > --===============3674382961333109643== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101475/

Ship it!

Would that=
 not simply make the reverse true, i.e. the dialog might be too large in th=
e opposite direction ? Anyhow, at least it won't be outside of the konq=
ueror window ; so I personally have no objections to this.

- Dawit

On May 30th, 2011, 8:26 p.m., Burkhard L=C3=BCck wrote:

Review request for KDE Base Apps, Dawit Alemayehu and David Faure.

By Burkhard L=C3=BCck.

Updated May 30, 2011, 8:26 p.m.

Descripti= on

Currently the add search engine window is left aligned to th=
e left side of the search bar. E. g. using locales with long translations o=
f the window title "Set URI Shortcuts" (or other strings in the w=
indow) like eg fr part of the window to add the search engine is outside th=
e screen, because the translated string is longer than the search bar. =

The patch makes the window right aligned at the end of the search bar, than=
 no matter how long the translated string is the whole window will be alway=
s inside konquerors main window.

Screenshot in locale fr before the patch showing the bug: http://bugsfiles.=
kde.org/attachment.cgi?id=3D52424

Screenshot in locale fr with the patch (one with / one without throbber): h=
ttp://bugsfiles.kde.org/attachment.cgi?id=3D60484

Bugs: 253879

Diffs=

konq-plugins/searchbar/searchbar.cpp (c7aa= 301)

--===============3674382961333109643==--