[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: DolphinColumnView navigation works more
From:       "Peter Penz" <peter.penz19 () gmail ! com>
Date:       2011-05-27 21:28:58
Message-ID: 20110527212858.8944.63194 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101449/#review3551
-----------------------------------------------------------

Ship it!


Thanks for the patch! Looks good, please push it to master :-)

- Peter


On May 27, 2011, 4:04 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101449/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 4:04 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> If no item is selected then pressing right moves to a column view with child url, \
> instead of the first index. 
> 
> This addresses bug 263110.
> http://bugs.kde.org/show_bug.cgi?id=263110
> 
> 
> Diffs
> -----
> 
> dolphin/src/views/dolphincolumnview.h be50ea3 
> dolphin/src/views/dolphincolumnview.cpp fa1f620 
> 
> Diff: http://git.reviewboard.kde.org/r/101449/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101449/">http://git.reviewboard.kde.org/r/101449/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! \
Looks good, please push it to master :-)</pre>  <br />







<p>- Peter</p>


<br />
<p>On May 27th, 2011, 4:04 p.m., Matthias Fuchs wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and Peter Penz.</div>
<div>By Matthias Fuchs.</div>


<p style="color: grey;"><i>Updated May 27, 2011, 4:04 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If no item is selected then pressing right moves to a column view with \
child url, instead of the first index.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=263110">263110</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>dolphin/src/views/dolphincolumnview.h <span style="color: \
grey">(be50ea3)</span></li>

 <li>dolphin/src/views/dolphincolumnview.cpp <span style="color: \
grey">(fa1f620)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101449/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic