[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: a very little fix
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2011-05-24 17:33:00
Message-ID: 20110524173300.27542.23392 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101433/#review3485
-----------------------------------------------------------
kdecore/config/kconfigdata.h
<http://git.reviewboard.kde.org/r/101433/#comment2943>
Even better, change it to log the previous value and the new one.
But look, it is commented.
- Jaime Torres
On May 24, 2011, 4:17 p.m., Guy Maurel wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101433/
> -----------------------------------------------------------
> =
> (Updated May 24, 2011, 4:17 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Summary
> -------
> =
> corrected to the right variable
> =
> =
> Diffs
> -----
> =
> kdecore/config/kconfigdata.h 0dff4ad =
> =
> Diff: http://git.reviewboard.kde.org/r/101433/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Guy
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101433/">http://git.reviewboard.kde.org/r/101433/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101433/diff/1/?file=18016#file18016line265" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdecore/config/kconfigdata.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KEntryMap : public QMap<KEntryKey, KEntry></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">265</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//qDebug() << "changing [" << group << \
"," << key << "] =" << <span \
class="hl">e.mV</span>alue;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">265</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//qDebug() << "changing [" << group << \
"," << key << "] =" << <span \
class="hl">v</span>alue;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even \
better, change it to log the previous value and the new one. But look, it is \
commented.</pre> </div>
<br />
<p>- Jaime Torres</p>
<br />
<p>On May 24th, 2011, 4:17 p.m., Guy Maurel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Guy Maurel.</div>
<p style="color: grey;"><i>Updated May 24, 2011, 4:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">corrected to the right variable</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/config/kconfigdata.h <span style="color: grey">(0dff4ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101433/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic