[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Display the tab title on root (/) folder properly
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-05-17 21:28:47
Message-ID: 20110517212847.422.14740 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101374/#review3367
-----------------------------------------------------------
konqueror/src/konqview.cpp
<http://git.reviewboard.kde.org/r/101374/#comment2805>
ahh... this is now missing both parentheses around the if statement and the \
opening brace.
- Dawit
On May 17, 2011, 9:18 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101374/
> -----------------------------------------------------------
>
> (Updated May 17, 2011, 9:18 p.m.)
>
>
> Review request for KDE Base Apps, David Faure and Peter Penz.
>
>
> Summary
> -------
>
> Konqueror in filemanager mode shows an empty tab title on browsing root (/) folder. \
> Dolphin displays the tab title on root (/) folder properly, so this patch is a copy \
> of three lines from dolphin dolphinmainwindow.cpp.
>
> This addresses bug 153573.
> http://bugs.kde.org/show_bug.cgi?id=153573
>
>
> Diffs
> -----
>
> konqueror/src/konqview.cpp 699c9d5
>
> Diff: http://git.reviewboard.kde.org/r/101374/diff
>
>
> Testing
> -------
>
> compiled and works for me
>
>
> Thanks,
>
> Burkhard
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101374/">http://git.reviewboard.kde.org/r/101374/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101374/diff/3/?file=16619#file16619line661" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/src/konqview.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KonqView::setCaption( const QString & caption )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">661</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="n">adjustedCaption</span><span \
class="p">.</span><span class="n">isEmpty</span><span class="p">()</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ahh... this \
is now missing both parentheses around the if statement and the opening brace.</pre> \
</div> <br />
<p>- Dawit</p>
<br />
<p>On May 17th, 2011, 9:18 p.m., Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Peter Penz.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 17, 2011, 9:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Konqueror in filemanager mode shows an empty tab title on browsing root \
(/) folder. Dolphin displays the tab title on root (/) folder properly, so this patch \
is a copy of three lines from dolphin dolphinmainwindow.cpp.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled and works for me</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=153573">153573</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqview.cpp <span style="color: grey">(699c9d5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101374/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic