From kde-core-devel Mon May 16 06:50:29 2011 From: "David Faure" Date: Mon, 16 May 2011 06:50:29 +0000 To: kde-core-devel Subject: Re: Review Request: konqueror: reset URL when pressing ESC in address Message-Id: <20110516065029.27495.88780 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130552991629162 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5699025571660611111==" --===============5699025571660611111== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/#review10125 ----------------------------------------------------------- Why do this in a key press handler? It means that hitting the Stop button w= ith the mouse and pressing the Esc key will do something different. Better do this in the slot connected to the stop action, then it will work = for both. - David On May 15, 2011, 7:59 p.m., Marcel Partap wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6681/ > ----------------------------------------------------------- > = > (Updated May 15, 2011, 7:59 p.m.) > = > = > Review request for kdelibs and David Faure. > = > = > Summary > ------- > = > Attempted patch to make konqueror reset the URL when escape is pressed in= the address bar. For reasons beyond my grokledge does not always seem to w= ork. > = > = > This addresses bug 257841. > https://bugs.kde.org/show_bug.cgi?id=3D257841 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 = > = > Diff: http://svn.reviewboard.kde.org/r/6681/diff > = > = > Testing > ------- > = > see https://bugs.kde.org/show_bug.cgi?id=3D257841#c0 > = > = > Thanks, > = > Marcel > = > --===============5699025571660611111== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6681/ 

Why do thi=
s in a key press handler? It means that hitting the Stop button with the mo=
use and pressing the Esc key will do something different.

Better do this in the slot connected to the stop action, then it will work =
for both.

- David


On May 15th, 2011, 7:59 p.m., Marcel Partap wrote:

Review request for kdelibs and David Faure.
By Marcel Partap.

Updated May 15, 2011, 7:59 p.m.

Descripti= on 

Attempted patch to make konqueror reset the URL when escape =
is pressed in the address bar. For reasons beyond my grokledge does not alw=
ays seem to work.

Testing <= /h1> 
see https://bugs.kde.org/show_bug.cgi?id=3D257841#c0
Bugs: 257841

Diffs=

  • /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp (1200388)

View Diff
--===============5699025571660611111==--