From kde-core-devel Wed May 11 16:47:42 2011 From: "Commit Hook" Date: Wed, 11 May 2011 16:47:42 +0000 To: kde-core-devel Subject: Re: Review Request: New KLauncher DBus interface to check for on hold Message-Id: <20110511164742.6977.25159 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130514463827676 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8593786572548886221==" --===============8593786572548886221== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101333/#review3265 ----------------------------------------------------------- This review has been submitted with commit c6ae48ccb5e809057a2d83888ad9181b= 2e5bc0ce by Dawit Alemayehu. - Commit On May 11, 2011, 3:58 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101333/ > ----------------------------------------------------------- > = > (Updated May 11, 2011, 3:58 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > As the summary state, this patch adds a new dbus interface to klaucher, c= heckForHeldSlave, that can be used to check whether or not there is an io s= lave being held for a given url. This fixes the last known issue with KIO's= put-on-hold feature not working properly. With this patch when a user clic= ks on a PDF link that points to an ftp server, KIO will no longer require m= ultiple connections to service that single request. > = > Please note that this fix is not specific to the ftp ioslave. Any ioslave= that optimizes its copy operation, i.e. supports the canCopyFromFile/canCo= pyToFile properties, benefits from this fix. > = > = > Diffs > ----- > = > kdecore/util/klauncher_iface.h 02c6c9b = > kinit/klauncher.h 3fbf2d7 = > kinit/klauncher.cpp dd45dfe = > kinit/klauncher_adaptor.h 0b045c8 = > kinit/klauncher_adaptor.cpp c7cf086 = > kio/kio/scheduler.cpp 34f437e = > kio/kio/slave.h 780f3c4 = > kio/kio/slave.cpp 3679ea9 = > = > Diff: http://git.reviewboard.kde.org/r/101333/diff > = > = > Testing > ------- > = > Clicking on the example links below should only result in one single conn= ection to the server: > = > ftp://ftp.kde.org/pub/kde/README_UPLOAD > ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf > = > = > Thanks, > = > Dawit > = > --===============8593786572548886221== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101333/ 

This revie=
w has been submitted with commit c6ae48ccb5e809057a2d83888ad9181b2e5bc0ce b=
y Dawit Alemayehu.

- Commit


On May 11th, 2011, 3:58 p.m., Dawit Alemayehu wrote:

Review request for kdelibs.
By Dawit Alemayehu.

Updated May 11, 2011, 3:58 p.m.

Descripti= on 

As the summary state, this patch adds a new dbus interface t=
o klaucher, checkForHeldSlave, that can be used to check whether or not the=
re is an io slave being held for a given url. This fixes the last known iss=
ue with KIO's put-on-hold feature not working properly. With this patch=
 when a user clicks on a PDF link that points to an ftp server, KIO will no=
 longer require multiple connections to service that single request.

Please note that this fix is not specific to the ftp ioslave. Any ioslave t=
hat optimizes its copy operation, i.e. supports the canCopyFromFile/canCopy=
ToFile properties, benefits from this fix.

Testing <= /h1> 
Clicking on the example links below should only result in on=
e single connection to the server:

ftp://ftp.kde.org/pub/kde/README_UPLOAD
ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf

Diffs=

  • kdecore/util/klauncher_iface.h (02c6c9b)
  • kinit/klauncher.h (3fbf2d7)
  • kinit/klauncher.cpp (dd45dfe)
  • kinit/klauncher_adaptor.h (0b045c8)=
  • kinit/klauncher_adaptor.cpp (c7cf086)
  • kio/kio/scheduler.cpp (34f437e)
  • kio/kio/slave.h (780f3c4)
  • kio/kio/slave.cpp (3679ea9)

View Diff
--===============8593786572548886221==--