'Review Request: Avoid resolving host names in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Avoid resolving host names in
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2011-05-11 18:17:42
Message-ID: 20110511181742.14020.43461 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101338/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This patch basically reverts commit 79c4ed8a7c7fe18f4c1d02d5faba5e7a412f57ae which \
was a workaround for bugs in hardware that is no longer applicable. The revert will \
ensure that a hostname and not an ip address is used for HTTPS over HTTP proxy (aka \
CONNECT) connections.


This addresses bug 207550.
    http://bugs.kde.org/show_bug.cgi?id=207550


Diffs
-----

  kio/kio/tcpslavebase.cpp 19e36c3 

Diff: http://git.reviewboard.kde.org/r/101338/diff


Testing
-------


Thanks,

Dawit


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101338/">http://git.reviewboard.kde.org/r/101338/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch basically reverts commit \
79c4ed8a7c7fe18f4c1d02d5faba5e7a412f57ae which was a workaround for bugs in hardware \
that is no longer applicable. The revert will ensure that a hostname and not an ip \
address is used for HTTPS over HTTP proxy (aka CONNECT) connections.</pre>  </td>
 </tr>
</table>




<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=207550">207550</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kio/kio/tcpslavebase.cpp <span style="color: grey">(19e36c3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101338/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic