[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: PATCH: Change the default KIO USERAGENT string.
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-05-11 16:00:06
Message-ID: 20110511160006.2840.78527 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101337/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
This patch changes the default user-agent string so that it is more aligned with \
other browsers by
- Dropping 'comptiable' and 'U' from the string.
- Making the platform string, e.g X11, mandatory part of the string.
- Sending the OS name and machine type (i686,x86-64) by default (configurable).
Additionally the patch for kprotocolmanager.cpp also removes the manual use of '%' to \
append text since kdelibs is now compilable with the QT_USE_FAST_CONCATENATION and \
QT_USE_FAST_OPERATOR_PLUS flags.
Besides being good for privacy due to less differentiation, this change should make \
it less likely that a different page will be sent sheerly based on user-agent \
sniffing. See the attached screen shot for what the full, default, and minimal \
default user-agent will look like now.
This addresses bug 271720.
http://bugs.kde.org/show_bug.cgi?id=271720
Diffs
-----
kio/kio/http_slave_defaults.h af97cfa
kio/kio/kprotocolmanager.cpp 57ec696
Diff: http://git.reviewboard.kde.org/r/101337/diff
Testing
-------
Screenshots
-----------
UserAgent [FULL]
http://git.reviewboard.kde.org/r/101337/s/163/
UserAgent [Default]
http://git.reviewboard.kde.org/r/101337/s/164/
UserAgent [Minimal]
http://git.reviewboard.kde.org/r/101337/s/165/
Thanks,
Dawit
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101337/">http://git.reviewboard.kde.org/r/101337/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes the default user-agent string so that it is more \
aligned with other browsers by
- Dropping 'comptiable' and 'U' from the string.
- Making the platform string, e.g X11, mandatory part of the string.
- Sending the OS name and machine type (i686,x86-64) by default (configurable).
Additionally the patch for kprotocolmanager.cpp also removes the manual use of \
'%' to append text since kdelibs is now compilable with the \
QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS flags.
Besides being good for privacy due to less differentiation, this change should make \
it less likely that a different page will be sent sheerly based on user-agent \
sniffing. See the attached screen shot for what the full, default, and minimal \
default user-agent will look like now.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=271720">271720</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/http_slave_defaults.h <span style="color: grey">(af97cfa)</span></li>
<li>kio/kio/kprotocolmanager.cpp <span style="color: grey">(57ec696)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101337/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101337/s/163/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-full_1_400x100.png" \
style="border: 1px black solid;" alt="UserAgent [FULL]" /></a>
<a href="http://git.reviewboard.kde.org/r/101337/s/164/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-default_1_400x100.png" \
style="border: 1px black solid;" alt="UserAgent [Default]" /></a>
<a href="http://git.reviewboard.kde.org/r/101337/s/165/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/05/11/useragent-minimal_400x100.png" \
style="border: 1px black solid;" alt="UserAgent [Minimal]" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic