This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101333/

Review request for kdelibs.
By Dawit Alemayehu.

Updated May 11, 2011, 3:58 p.m.

Changes

Updated testing information...

Description

As the summary state, this patch adds a new dbus interface to klaucher, checkForHeldSlave, that can be used to check whether or not there is an io slave being held for a given url. This fixes the last known issue with KIO's put-on-hold feature not working properly. With this patch when a user clicks on a PDF link that points to an ftp server, KIO will no longer require multiple connections to service that single request.

Please note that this fix is not specific to the ftp ioslave. Any ioslave that optimizes its copy operation, i.e. supports the canCopyFromFile/canCopyToFile properties, benefits from this fix.

Testing (updated)

Clicking on the example links below should only result in one single connection to the server:

ftp://ftp.kde.org/pub/kde/README_UPLOAD
ftp://ftp.kde.org/pub/kde/printing/kdeprint-handbook.pdf

Diffs

  • kdecore/util/klauncher_iface.h (02c6c9b)
  • kinit/klauncher.h (3fbf2d7)
  • kinit/klauncher.cpp (dd45dfe)
  • kinit/klauncher_adaptor.h (0b045c8)
  • kinit/klauncher_adaptor.cpp (c7cf086)
  • kio/kio/scheduler.cpp (34f437e)
  • kio/kio/slave.h (780f3c4)
  • kio/kio/slave.cpp (3679ea9)

View Diff