On May 9th, 2011, 7:37 p.m., David Palacio wrote:

kdialog/kdialog.cpp (Diff revision 1)
static int directCommand(KCmdLineArgs *args)
		366	KCmdLineArgs *qtargs = KCmdLineArgs::parsedArgs("qt"); // --icon is a qt option

--icon is a KDE option.
Maybe that's why the first diff did not work?

I’ll try again using --icon KDE option

On May 9th, 2011, 7:37 p.m., David Palacio wrote:

kdialog/kdialog.cpp (Diff revision 5)
bool sendVisualNotification(QString text, QString title, int timeout)
99	bool sendVisualNotification(QString text, QString title, int timeout)	101	bool sendVisualNotification(QString text, const QString &title, const QString &icon, int duration)

s/duration/timeout
There's no need to change this name here and you change it backwards some lines below. KDialog's usage text names this option "timeout" as well.

That was some experiment and I forgot to completely revert it. Will change it ;)

- Kai Uwe

On May 6th, 2011, 2:52 p.m., Kai Uwe Broulik wrote:

Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma notifications as well.
I saw that the icon was hardcoded to dialog-information and tried to enable it to parse the --icon command line argument and pass it to the dbus call that triggers the notification.
I could not test the patch however, since I do not (yet) have a full development environment or its dependencies, and I do not even know if this is the right approach, but I hope you can have a look at it.