This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101312/

On May 9th, 2011, 10:45 p.m., Aur=C3=A9lien= G=C3=A2teau wrote:

Looks goo=
d. I would even go a bit further and suggest the following:
- Remove the Clear button, I don't think it serves any purpose
- Change the label of the OK button to "Create Link"

On May 10th, 2011, 10:54 a.m., Jonathan Marten wrote:

Good idea=
 to remove the pointless Clear button (probably a hangover from the days wh=
en line edit's didn't have clear buttons).  Not possible to change =
the OK button text, though, because this is a general dialogue which may be=
 used in other places.

On May 10th, 2011, 10:54 a.m., Christoph Feck wrote:

I think t=
he dialog is more generic and is (could?) also be used by programs for addi=
ng bookmarks or something else, so labeling the button "Create Link&qu=
ot; could be confusing.

The Clear button is really a relict, and it can be removed if the fields ha=
ve a standard KLineEdit clear button already.

On May 10th, 2011, 10:55 a.m., Christoph Feck wrote:

Oh, two i=
diots adding the same comment at the same time ;)

No no, one =
idiot did not realize it was a generic method, and two smart developers cor=
rected him :)

- Aur=C3=A9lien

On May 8th, 2011, 3:42 p.m., Jonathan Marten wrote:

Review request for kdelibs.

By Jonathan Marten.

Updated May 8, 2011, 3:42 p.m.

Descripti= on

This dialogue - used, for example, for the desktop's &qu=
ot;Create New - Link to Location" or "Create New - Basic link to&=
quot; actions, has a very ugly layout where the labels are squashed up to t=
he entry fields and the two lines are not vertically aligned with each othe=
r.  This change uses a form layout instead, which automatically adopts the =
standard KDE style and spacing.

In addition to the layout, the "OK" button is enabled when the di=
alogue is first shown; it should not be because the two entry fields are em=
pty. This is checked at the end of the constructor.

Testing <= /h1>

Built kdelibs with these changes, checked operation and appe=
arance of dialogue via Plasma desktop.

Diffs=

kfile/knameandurlinputdialog.cpp (fd02af6)=

View Diff

Screensho= ts

Descripti= on

Testing <= /h1> Built kdelibs with these changes, checked operation and appe= arance of dialogue via Plasma desktop.

Diffs=

Screensho= ts

Testing <= /h1>

Built kdelibs with these changes, checked operation and appe= arance of dialogue via Plasma desktop.