--===============8337592715264871975== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3233 ----------------------------------------------------------- Looks good. I would even go a bit further and suggest the following: - Remove the Clear button, I don't think it serves any purpose - Change the label of the OK button to "Create Link" - Aur=C3=A9lien On May 8, 2011, 3:42 p.m., Jonathan Marten wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101312/ > ----------------------------------------------------------- > = > (Updated May 8, 2011, 3:42 p.m.) > = > = > Review request for kdelibs. > = > = > Summary > ------- > = > This dialogue - used, for example, for the desktop's "Create New - Link t= o Location" or "Create New - Basic link to" actions, has a very ugly layout= where the labels are squashed up to the entry fields and the two lines are= not vertically aligned with each other. This change uses a form layout in= stead, which automatically adopts the standard KDE style and spacing. > = > In addition to the layout, the "OK" button is enabled when the dialogue i= s first shown; it should not be because the two entry fields are empty. Thi= s is checked at the end of the constructor. > = > = > Diffs > ----- > = > kfile/knameandurlinputdialog.cpp fd02af6 = > = > Diff: http://git.reviewboard.kde.org/r/101312/diff > = > = > Testing > ------- > = > Built kdelibs with these changes, checked operation and appearance of dia= logue via Plasma desktop. > = > = > Screenshots > ----------- > = > Before > http://git.reviewboard.kde.org/r/101312/s/158/ > After > http://git.reviewboard.kde.org/r/101312/s/159/ > = > = > Thanks, > = > Jonathan > = > --===============8337592715264871975== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101312/ 

Looks good=
. I would even go a bit further and suggest the following:
- Remove the Clear button, I don't think it serves any purpose
- Change the label of the OK button to "Create Link"

- Aur=C3=A9lien


On May 8th, 2011, 3:42 p.m., Jonathan Marten wrote:

Review request for kdelibs.
By Jonathan Marten.

Updated May 8, 2011, 3:42 p.m.

Descripti= on 

This dialogue - used, for example, for the desktop's &qu=
ot;Create New - Link to Location" or "Create New - Basic link to&=
quot; actions, has a very ugly layout where the labels are squashed up to t=
he entry fields and the two lines are not vertically aligned with each othe=
r.  This change uses a form layout instead, which automatically adopts the =
standard KDE style and spacing.

In addition to the layout, the "OK" button is enabled when the di=
alogue is first shown; it should not be because the two entry fields are em=
pty. This is checked at the end of the constructor.

Testing <= /h1> 
Built kdelibs with these changes, checked operation and appe=
arance of dialogue via Plasma desktop.

Diffs=

  • kfile/knameandurlinputdialog.cpp (fd02af6)=

View Diff

Screensho= ts

3D"Bef= 3D"Afte=
--===============8337592715264871975==--