From kde-core-devel  Mon May 09 08:24:03 2011
From: Nikhil Marathe <nsm.nikhil () gmail ! com>
Date: Mon, 09 May 2011 08:24:03 +0000
To: kde-core-devel
Subject: Re: Request: Inclusion of kio-upnp-ms to kde-runtime KIO slaves
Message-Id: <BANLkTimjj1Gv1dB=FZVDm_jNTGrV6YjfYQ () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130492878922289

On Sat, May 7, 2011 at 5:21 PM, Friedrich W. H. Kossebau
<kossebau@kde.org> wrote:
>
> * Needed in toplevel CMakeLists.txt so FindHUpnp.cmake is found (might stop
> people giving it a try):
> set( CMAKE_MODULE_PATH  ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR} )

FindHUpnp.cmake is already in kdelibs/cmake. So I don't think this is required.

> * As there is no docu yet, this line should be removed in
> kio_upnp_ms.protocol:
> DocPath=kioslave/kio_upnp_ms.html
done

> * upnptypes.h better is renamed to upnp-ms-types.h or similar
done

> * renamed upnptypes.h also would be added to kdelibs, as kde-runtime should
> not be a compile-time dep. And then ideally merged into kio/udsentry.h, like
> e.g. the Nepomuk ones are already

How should I approach this? Should I create a separate review request
for the UDSEntry addition
later, or should I do it now? Will this break binary compatibility?
The compile time dependency is only for programs which will treat UPnP
as special, and not normal kioslave users who use them via the Job interface.

Nikhil