[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add KMessageWidget, an alternative to KMessageBox
From: "Andrea Diamantini" <adjam7 () gmail ! com>
Date: 2011-04-30 10:12:33
Message-ID: 20110430101233.20128.27520 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101249/#review2984
-----------------------------------------------------------
I cannot properly review your code. Ill just say I like this new GUI object very \
much! many thanks for :)
- Andrea
On April 29, 2011, 1:44 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101249/
> -----------------------------------------------------------
>
> (Updated April 29, 2011, 1:44 p.m.)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> KMessageWidget is a new widget which can be considered as a less intrusive \
> alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( \
> http://community.kde.org/Sprints/UX2011/KMessageWidget ).
> The class documentation should make it clear how and when it can be used.
>
> This widget could be used by:
> - Browsers to implement their "remember password" widgets (Konqueror, Rekonq...)
> - Forms to provide feedback on validation errors
> - Bluedevil KCM to replace its custom "No Bluetooth adapter have been found" \
> message widget
> - Nepomuk/Strigi KCM to indicate status of their services
> - Gwenview to replace its custom save bar
> - ...
>
> I still have a few additions in mind for the API but it is already usable and since \
> we are freezing I think it can be merged in master in its current state. I assume \
> it will still be possible to extend the API a bit before kdelibs 4.7 freezes for \
> good.
> I also wrote an example program in the kdeexample repository ( \
> https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget \
> ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more \
> a manual test program than an example.
>
> Diffs
> -----
>
> kdeui/CMakeLists.txt d1873d1
> kdeui/widgets/kmessagewidget.h PRE-CREATION
> kdeui/widgets/kmessagewidget.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101249/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Montage from kmessagewidgetdemo
> http://git.reviewboard.kde.org/r/101249/s/141/
>
>
> Thanks,
>
> Aurélien
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101249/">http://git.reviewboard.kde.org/r/101249/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I cannot properly review \
your code. Ill just say I like this new GUI object very much! many thanks for \
:)</pre> <br />
<p>- Andrea</p>
<br />
<p>On April 29th, 2011, 1:44 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated April 29, 2011, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KMessageWidget is a new widget which can be considered as a less \
intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( \
http://community.kde.org/Sprints/UX2011/KMessageWidget ).
The class documentation should make it clear how and when it can be used.
This widget could be used by:
- Browsers to implement their "remember password" widgets (Konqueror, \
Rekonq...)
- Forms to provide feedback on validation errors
- Bluedevil KCM to replace its custom "No Bluetooth adapter have been \
found" message widget
- Nepomuk/Strigi KCM to indicate status of their services
- Gwenview to replace its custom save bar
- ...
I still have a few additions in mind for the API but it is already usable and since \
we are freezing I think it can be merged in master in its current state. I assume it \
will still be possible to extend the API a bit before kdelibs 4.7 freezes for good.
I also wrote an example program in the kdeexample repository ( \
https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget \
), though I am wondering whether it shouldn't be moved in kdeui/tests as it is \
more a manual test program than an example.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(d1873d1)</span></li>
<li>kdeui/widgets/kmessagewidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kdeui/widgets/kmessagewidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101249/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/101249/s/141/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/04/28/kmessagewidget_400x100.png" \
style="border: 1px black solid;" alt="Montage from kmessagewidgetdemo" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic