[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Do not preserve username information on
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2011-04-21 14:00:34
Message-ID: 20110421140034.17669.72505 () vidsolbach ! de
[Download RAW message or body]
> On April 21, 2011, 8:18 a.m., David Faure wrote:
> > No objections, although I don't have the big picture about this.
Its main purpose is to make the scenario below possible as part of the ftp =
login fixes I am working on under https://git.reviewboard.kde.org/r/100873/
1.) User enters a ftp url, ftp://foo@foobar.com
2.) Gets prompted to enter the password by kio_ftp.
3.) Changes mind and clicks on the "Anonymous" check box and presses OK.
Now the user name in the client needs to be updated to blank since the user=
chose to login anonymously. That is what this patch makes possible. It all=
ows us to send a redirected without any user name, even though the original=
typed-in url contained one. Hope that clarifies things.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101153/#review2799
-----------------------------------------------------------
On April 21, 2011, 2:50 a.m., Dawit Alemayehu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101153/
> -----------------------------------------------------------
> =
> (Updated April 21, 2011, 2:50 a.m.)
> =
> =
> Review request for kdelibs and David Faure.
> =
> =
> Summary
> -------
> =
> This patch completely removes the automatic restoration of the user name =
from the original url to the redirection url at the job level. Even though =
I tried to lookup why this was done a long time ago, I have not been able t=
o decipher the reason behind it. I could only guess that it was probably do=
ne as a workaround for the deficiencies of some unknown ioslave that was no=
t doing the right thing when constructing the redirection url.
> =
> Unfortunately this has now come in full circle to cause problems when att=
empting to fix kio_ftp's login related bug reports. Namely I wanted to fix =
the problem where the user typed a username as part of the ftp url and late=
r on either changed it or choose to login anonymously when prompted with a =
password dialog. Right now the client never gets updated even when the user=
chose to use a different username in the password dialog. IOW, the usernam=
e reflected in the typed-in url is different from the one the user used to =
login. You can guess what happens when the user then clicks on a folder or =
file after logging in.
> =
> The process I chose to use to update the client is to cause a redirection=
and that works fine so long as the redirection url contains a proper usern=
ame. Otherwise, the redirection handling slots in KIO::Job automatically re=
-insert the username from the old url into the new redirection url.
> =
> =
> Diffs
> -----
> =
> kio/kio/job.cpp 004b4c9 =
> =
> Diff: http://git.reviewboard.kde.org/r/101153/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dawit
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101153/">http://git.reviewboard.kde.org/r/101153/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 21st, 2011, 8:18 a.m., <b>David Faure</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No \
objections, although I don't have the big picture about this.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Its main purpose is to \
make the scenario below possible as part of the ftp login fixes I am working on under \
https://git.reviewboard.kde.org/r/100873/
1.) User enters a ftp url, ftp://foo@foobar.com
2.) Gets prompted to enter the password by kio_ftp.
3.) Changes mind and clicks on the "Anonymous" check box and presses OK.
Now the user name in the client needs to be updated to blank since the user chose to \
login anonymously. That is what this patch makes possible. It allows us to send a \
redirected without any user name, even though the original typed-in url contained \
one. Hope that clarifies things.</pre> <br />
<p>- Dawit</p>
<br />
<p>On April 21st, 2011, 2:50 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 21, 2011, 2:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch completely removes the automatic restoration of the user name \
from the original url to the redirection url at the job level. Even though I tried to \
lookup why this was done a long time ago, I have not been able to decipher the reason \
behind it. I could only guess that it was probably done as a workaround for the \
deficiencies of some unknown ioslave that was not doing the right thing when \
constructing the redirection url.
Unfortunately this has now come in full circle to cause problems when attempting to \
fix kio_ftp's login related bug reports. Namely I wanted to fix the problem where \
the user typed a username as part of the ftp url and later on either changed it or \
choose to login anonymously when prompted with a password dialog. Right now the \
client never gets updated even when the user chose to use a different username in the \
password dialog. IOW, the username reflected in the typed-in url is different from \
the one the user used to login. You can guess what happens when the user then clicks \
on a folder or file after logging in.
The process I chose to use to update the client is to cause a redirection and that \
works fine so long as the redirection url contains a proper username. Otherwise, the \
redirection handling slots in KIO::Job automatically re-insert the username from the \
old url into the new redirection url.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/job.cpp <span style="color: grey">(004b4c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic