From kde-core-devel Thu Apr 14 07:34:44 2011 From: "Sebastian Trueg" Date: Thu, 14 Apr 2011 07:34:44 +0000 To: kde-core-devel Subject: Re: Review Request: fix broken nepomuk ui files to make messages Message-Id: <20110414073444.9228.77292 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=130276653029448 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0824296111817316990==" --===============0824296111817316990== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101112/#review2626 ----------------------------------------------------------- Ship it! Looks fine to me. I simply used the designer field that said "comment". But= I just checked - it might be that the german translation of Designer is a = bit weird: "Kennung" seems to be the one to use instead of "Kommentar". - Sebastian On April 13, 2011, 2:04 p.m., Burkhard L=C3=BCck wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101112/ > ----------------------------------------------------------- > = > (Updated April 13, 2011, 2:04 p.m.) > = > = > Review request for KDE Runtime and Sebastian Trueg. > = > = > Summary > ------- > = > Some nepomuk ui files have strings like so= me message > xgettext extracts this properly to msgctxt "@info" msgid "some message" > ui compiler generates tr2i18n("some message", 0) -> that does not match x= gettext, therefore no translated msg is found > = > With some message > the ui compiler generates tr2i18n("some message", "@info"), that does mat= ch xgettext and the translated msg is found and shown > = > = > Diffs > ----- > = > nepomuk/kcm/nepomukconfigwidget.ui 5652274 = > nepomuk/services/backupsync/gui/backupsettingspage.ui e28a7f5 = > nepomuk/services/backupsync/gui/intropage.ui 1a74630 = > nepomuk/services/backupsync/gui/restoreselection.ui 157c50a = > = > Diff: http://git.reviewboard.kde.org/r/101112/diff > = > = > Testing > ------- > = > Tested using locale x-test (http://techbase.kde.org/Development/Tutorials= /Localization/Building_KDE's_l10n_Module), = > messages are translated > = > = > Thanks, > = > Burkhard > = > --===============0824296111817316990== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101112/

Ship it!

Looks fine=
 to me. I simply used the designer field that said "comment". But=
 I just checked - it might be that the german translation of Designer is a =
bit weird: "Kennung" seems to be the one to use instead of "=
Kommentar".

- Sebastian


On April 13th, 2011, 2:04 p.m., Burkhard L=C3=BCck wrote:

Review request for KDE Runtime and Sebastian Trueg.
By Burkhard L=C3=BCck.

Updated April 13, 2011, 2:04 p.m.

Descripti= on 

Some nepomuk ui files have strings like <string extracomm=
ent=3D"@info">some message</string>
xgettext extracts this properly to msgctxt "@info" msgid "so=
me message"
ui compiler generates tr2i18n("some message", 0) -> that does =
not match xgettext, therefore no translated msg is found

With <string comment=3D"@info">some message</string>
the ui compiler generates tr2i18n("some message", "@info&quo=
t;), that does match xgettext and the translated msg is found and shown

Testing <= /h1> 
Tested using locale x-test (http://techbase.kde.org/Developm=
ent/Tutorials/Localization/Building_KDE's_l10n_Module), =

messages are translated

Diffs=

  • nepomuk/kcm/nepomukconfigwidget.ui (565227= 4)
  • nepomuk/services/backupsync/gui/backupsettingspage.ui (e28a7f5)
  • nepomuk/services/backupsync/gui/intropage.ui (1a74630)
  • nepomuk/services/backupsync/gui/restoreselection.ui (157c50a)

View Diff
--===============0824296111817316990==--